Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Received Feedback Request: 'Deny' Option #2622

Draft
wants to merge 12 commits into
base: develop
Choose a base branch
from

Conversation

thelenw
Copy link
Collaborator

@thelenw thelenw commented Oct 8, 2024

  • Added deny/decline button on Received Feedback Request
  • Implemented required dialogue for reason input
  • Working on backend support for automated removal of Request for recipient + notification for sender

@thelenw thelenw self-assigned this Oct 8, 2024
@mkimberlin mkimberlin marked this pull request as draft October 8, 2024 20:09
@thelenw thelenw closed this Oct 26, 2024
@thelenw
Copy link
Collaborator Author

thelenw commented Oct 29, 2024

Reopened for implementation of feature further to stand-up meeting 10/29/24

@thelenw thelenw reopened this Oct 29, 2024
@thelenw
Copy link
Collaborator Author

thelenw commented Oct 29, 2024

Full 'Decline' option for non-admin users is requested, against current permissions formatting for 'Cancel' request as admin but not standard user. A separate 'Decline' feature will be added, to support standard user denial of Received Feedback Requests.

…o implement complete functionality to allow standard users the ability to deny feedback requests (as a new method with separate permission). The notification service is not yet complete, and some review facets need to be revisited. This is a valuable commit to save progress and clarify working state of long-outstanding PR draft.
…and sendNotification function remain outstanding issues.
@thelenw
Copy link
Collaborator Author

thelenw commented Nov 13, 2024

Standard users can deny requests on Feedback > Received Requests by providing a reason. The denial of those requests, along with the reason a user provides, is stored in the database effectively and determines the state of the page. A separate notification service must be implemented to effectively update respective requesting users about feedback request denials. @mkimberlin must advise on whether to implement notification service as a new branch, or continue work here. The question of scope applies; should notification service be designed for feedback request denials specifically, or as a broader and more accessible service for the Check-Ins system? If the latter, my instinct is new PR. Thank you Michael for many valuable inputs here, and in advance for reviewing changes + ultimate decision on further procedure.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants