-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Received Feedback Request: 'Deny' Option #2622
base: develop
Are you sure you want to change the base?
Conversation
thelenw
commented
Oct 8, 2024
- Added deny/decline button on Received Feedback Request
- Implemented required dialogue for reason input
- Working on backend support for automated removal of Request for recipient + notification for sender
Reopened for implementation of feature further to stand-up meeting 10/29/24 |
Full 'Decline' option for non-admin users is requested, against current permissions formatting for 'Cancel' request as admin but not standard user. A separate 'Decline' feature will be added, to support standard user denial of Received Feedback Requests. |
…from feedback_request backend service.
.../java/com/objectcomputing/checkins/services/feedback_request/DTO/DenyFeedbackRequestDTO.java
Show resolved
Hide resolved
server/src/main/resources/db/common/V116__alter_feedback_requests_table.sql
Outdated
Show resolved
Hide resolved
.../java/com/objectcomputing/checkins/services/feedback_request/DTO/DenyFeedbackRequestDTO.java
Outdated
Show resolved
Hide resolved
...n/java/com/objectcomputing/checkins/services/feedback_request/FeedbackRequestController.java
Show resolved
Hide resolved
...in/java/com/objectcomputing/checkins/services/feedback_request/FeedbackRequestCreateDTO.java
Show resolved
Hide resolved
server/src/main/java/com/objectcomputing/checkins/services/permissions/Permission.java
Outdated
Show resolved
Hide resolved
…o implement complete functionality to allow standard users the ability to deny feedback requests (as a new method with separate permission). The notification service is not yet complete, and some review facets need to be revisited. This is a valuable commit to save progress and clarify working state of long-outstanding PR draft.
…and sendNotification function remain outstanding issues.
Standard users can deny requests on |