Skip to content

Commit

Permalink
Removed the workaround for dealing with default review assignments ov…
Browse files Browse the repository at this point in the history
…erwriting chosen review assignments.
  • Loading branch information
ocielliottc committed Oct 18, 2024
1 parent 99af92b commit cbe1f57
Showing 1 changed file with 1 addition and 7 deletions.
8 changes: 1 addition & 7 deletions web-ui/src/components/reviews/TeamReviews.jsx
Original file line number Diff line number Diff line change
Expand Up @@ -204,12 +204,6 @@ const TeamReviews = ({ onBack, periodId }) => {
};

const loadTeamMembers = () => {
// If we already have a list of team members, we should not overwrite the
// list with the original list of team members.
if (teamMembers.length > 0) {
return;
}

let source;
if (!approvalMode || (isAdmin && showAll)) {
source = currentMembers;
Expand All @@ -224,7 +218,7 @@ const TeamReviews = ({ onBack, periodId }) => {
// Always filter the members down to existing selected assignments.
// We do not want to add members that were not already selected.
const memberIds = assignments.map(a => a.revieweeId);
let members = source.filter(m => memberIds.includes(m.id));
const members = source.filter(m => memberIds.includes(m.id));
setTeamMembers(members);
};

Expand Down

0 comments on commit cbe1f57

Please sign in to comment.