Skip to content

Commit

Permalink
Revert "Try again with AOT to see if it speeds things up"
Browse files Browse the repository at this point in the history
It does seem to improve startup time, but I don't think it belongs in this PR

This reverts commit 51094e5.
  • Loading branch information
timyates committed Sep 17, 2024
1 parent 51094e5 commit 097ffca
Show file tree
Hide file tree
Showing 3 changed files with 2 additions and 25 deletions.
2 changes: 1 addition & 1 deletion .github/workflows/gradle-build-native-feature.yml
Original file line number Diff line number Diff line change
Expand Up @@ -41,4 +41,4 @@ jobs:
- name: Build a native docker image
uses: gradle/gradle-build-action@4137be6a8bf7d7133955359dbd952c0ca73b1021
with:
arguments: optimizedDockerBuildNative
arguments: dockerBuildNative
2 changes: 1 addition & 1 deletion .github/workflows/gradle-deploy-native-develop.yml
Original file line number Diff line number Diff line change
Expand Up @@ -56,7 +56,7 @@ jobs:
run: |-
gcloud --quiet auth configure-docker
- name: Build a native docker image
run: ./gradlew optimizedDockerBuildNative
run: ./gradlew dockerBuildNative
env:
VITE_APP_API_URL: https://checkins-develop-native-832140020593.us-central1.run.app
- name: Push the Docker image to Google Container Registry
Expand Down
23 changes: 0 additions & 23 deletions server/build.gradle
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,6 @@ plugins {
id 'maven-publish'
id("com.gradleup.shadow") version "8.3.1"
id("io.micronaut.application") version "4.4.0"
id("io.micronaut.aot") version "4.4.0"
id "jacoco"
id("org.openrewrite.rewrite") version "latest.release"
}
Expand All @@ -27,20 +26,6 @@ micronaut {
incremental(true)
annotations("com.objectcomputing.checkins.*")
}
aot {
// Please review carefully the optimizations enabled below
// Check https://micronaut-projects.github.io/micronaut-aot/latest/guide/ for more details
optimizeServiceLoading = false
convertYamlToJava = false
precomputeOperations = true
cacheEnvironment = true
optimizeClassLoading = true
deduceEnvironment = true
optimizeNetty = true
replaceLogbackXml = true
configurationProperties.put("micronaut.security.jwks.enabled","false")
configurationProperties.put("micronaut.security.openid-configuration.enabled","false")
}
}

dockerBuildNative {
Expand All @@ -51,14 +36,6 @@ dockerBuildNative {
images = ["checkins:latest"] + imageNameFromGithub
}

optimizedDockerBuildNative {
def imageNameFromGithub = []
if (System.getenv('PROJECT_ID') != null && System.getenv('SERVICE_NAME') && System.getenv('GITHUB_SHA')) {
imageNameFromGithub = ["gcr.io/${System.getenv('PROJECT_ID')}/${System.getenv('SERVICE_NAME')}:${System.getenv("GITHUB_SHA")}".toString()]
}
images = ["checkins:latest"] + imageNameFromGithub
}

graalvmNative {
toolchainDetection = false
binaries {
Expand Down

0 comments on commit 097ffca

Please sign in to comment.