Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve libvlc.dll detection #144

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

pjeanjean
Copy link
Contributor

This doesn't actually fix #140 , but it should probably help users that are using a 32bits version of Python on Windows, and it should also help to debug future issues with the DLL detection function.

Check also `Program Files (x86)`
Make error message more explicit
@kethan1
Copy link

kethan1 commented Oct 11, 2020

No code change can fix #140 as that was caused because of using 64 bit python with 32 bit VLC.

@kethan1
Copy link

kethan1 commented Dec 4, 2020

@oaubert any plans on merging this

@oaubert
Copy link
Owner

oaubert commented Dec 4, 2020

I was waiting for some feedback on my suggestion to merge this with #152 and provide more explicit error messages for the various error cases (which may also point to some FAQ). I was also thinking especially about the #140 use case (which is a very FAQ): ideally, if you can find the DLL file but cannot load it, it should display an error message giving the procedure to check the architecture for VLC (and display the arch for python). This needs to be done by a Windows developer.
But if you do not have the time, your current patch could be merged almost as-is (except that I would rather have only the header.py file modified, not the generated modules themselves).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Error When Importing VLC
3 participants