Add encryptCallData() to gasless chapter and example #477
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for oasisprotocol-sapphire-paratime ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
matevz
force-pushed
the
matevz/docs/encryptcalldata
branch
2 times, most recently
from
f5ff7d0 to
d0d56b2
Compare
matevz
force-pushed
the
matevz/docs/encryptcalldata
branch
2 times, most recently
from
9b80896 to
7273f83
Compare
matevz
force-pushed
the
matevz/docs/encryptcalldata
branch
from
7273f83 to
7cfbc50
Compare
ptrus
reviewed
Dec 24, 2024
| solidity: { | ||
| version: '0.8.20', | ||
| settings: { | ||
| // XXX: Needs to match https://github.com/oasisprotocol/sapphire-paratime/blob/main/contracts/hardhat.config.ts |
There was a problem hiding this comment.
Based on some of my quick testing I believe it is not about matching, but actually things fail without this optimization enabled.
For example, removing this optimization in contracts/hardhat.config.ts makes the tests in contracts/ fail as well.
Do we know why this happens? Should someone investigate this further?
rube-de
reviewed
Dec 24, 2024
| const tx = await commentBox.comment('Hello, world!'); | ||
| await tx.wait(); | ||
| // TODO: https://github.com/oasisprotocol/sapphire-paratime/issues/179 | ||
| const response = await provider.broadcastTransaction(tx); |
There was a problem hiding this comment.
calldata encryption could be checked here (requires sapphire-paratime import)
Suggested change
| const response = await provider.broadcastTransaction(tx); | |
| const response = await provider.broadcastTransaction(tx); | |
| expect(isCalldataEnveloped(response.data)).eq(!plain); |
also is the TODO still open?
I used await wrapEthereumProvider(provider).broadcastTransaction(tx) and didn't got an error.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR:
encryptCallData()ingasless.mdto generate encrypted gasless transactionencryptCallData()toexamples/onchain-signerand tests itPREVIEW
Fixes #463.