-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: SIWE tutorial #459
Open
matevz
wants to merge
2
commits into
main
Choose a base branch
from
matevz/docs/siwe-tutorial
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
docs: SIWE tutorial #459
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change | ||||
---|---|---|---|---|---|---|
|
@@ -16,17 +16,18 @@ struct Bearer { | |||||
/** | ||||||
* @title Base contract for SIWE-based authentication | ||||||
* @notice Inherit this contract, if you wish to enable SIWE-based | ||||||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Suggested change
|
||||||
* authentication for your contract methods that require authenticated calls. | ||||||
* authentication for your contract methods that require authentication. | ||||||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Suggested change
(optional) I read "functions" more in Solidity documentation? |
||||||
* The smart contract needs to be bound to a domain (passed in constructor). | ||||||
* | ||||||
* #### Example | ||||||
* | ||||||
* ```solidity | ||||||
* contract MyContract is SiweAuth { | ||||||
* address private _owner; | ||||||
* string private _message; | ||||||
* | ||||||
* modifier onlyOwner(bytes calldata bearer) { | ||||||
* if (authMsgSender(bearer) != _owner) { | ||||||
* if (msg.sender != _owner && authMsgSender(bearer) != _owner) { | ||||||
* revert("not allowed"); | ||||||
* } | ||||||
* _; | ||||||
|
@@ -37,7 +38,11 @@ struct Bearer { | |||||
* } | ||||||
* | ||||||
* function getSecretMessage(bytes calldata bearer) external view onlyOwner(bearer) returns (string memory) { | ||||||
* return "Very secret message"; | ||||||
* return _message; | ||||||
* } | ||||||
* | ||||||
* function setSecretMessage(string calldata message) external onlyOwner("") { | ||||||
* _message = message; | ||||||
* } | ||||||
* } | ||||||
* ``` | ||||||
|
@@ -144,13 +149,16 @@ contract SiweAuth is A13e { | |||||
return _domain; | ||||||
} | ||||||
|
||||||
function authMsgSender(bytes calldata bearer) | ||||||
function authMsgSender(bytes memory bearer) | ||||||
internal | ||||||
view | ||||||
override | ||||||
checkRevokedBearer(bearer) | ||||||
returns (address) | ||||||
{ | ||||||
if (bearer.length == 0) { | ||||||
return address(0); | ||||||
} | ||||||
bytes memory bearerEncoded = Sapphire.decrypt( | ||||||
_bearerEncKey, | ||||||
0, | ||||||
|
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.