contracts/tests: Fix flaky SIWE and gas cost #444
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for oasisprotocol-sapphire-paratime canceled.
|
matevz
force-pushed
the
matevz/fix/flaky-siwe-gascost
branch
from
c16165d to
6e142c6
Compare
aefhm
approved these changes
Oct 23, 2024
CedarMist
approved these changes
Oct 23, 2024
github-actions bot
added a commit
that referenced
this pull request
Oct 24, 2024
…atevz/fix/flaky-siwe-gascost contracts/tests: Fix flaky SIWE and gas cost a665ff3
github-actions bot
added a commit
that referenced
this pull request
Oct 24, 2024
…tevz/fix/flaky-siwe-gascost contracts/tests: Fix flaky SIWE and gas cost a665ff3
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #443 by waiting for the block with sufficiently new timestamp instead of fixed time.
Another workaround for #337.