Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

packaging: use PNPM for publishing, with correct tags #363

Merged
merged 2 commits into from
Aug 27, 2024

Conversation

CedarMist
Copy link
Member

@CedarMist CedarMist commented Aug 26, 2024

fixes: #362
includes: #358

extracts the following tags:

  • rc
  • next
  • alpha
  • beta

also enables NPM provenance when publishing

We can change the dist-tag for the latest tag: https://stackoverflow.com/questions/67813980/how-to-point-latest-dist-tag-to-a-previous-version-in-npm

npm dist-tag add <pkg name>@<version> latest

And release new versions under the appropriate alpha or beta tags. Maybe as @matevz recommended we should just use next ?

fixes: #362

extracts the following tags:

 * rc
 * next
 * alpha
 * beta

also enables NPM provenance when publishing
@CedarMist CedarMist self-assigned this Aug 26, 2024
@CedarMist CedarMist requested a review from aefhm August 26, 2024 20:08
Copy link

netlify bot commented Aug 26, 2024

Deploy Preview for oasisprotocol-sapphire-paratime canceled.

Name Link
🔨 Latest commit 3399339
🔍 Latest deploy log https://app.netlify.com/sites/oasisprotocol-sapphire-paratime/deploys/66ccfc96b020740008a518e4

@CedarMist CedarMist added javascript Pull requests that update JavaScript code and removed bug labels Aug 26, 2024
@CedarMist CedarMist requested a review from lukaw3d August 26, 2024 22:18
@CedarMist CedarMist marked this pull request as ready for review August 26, 2024 22:18
Copy link
Contributor

@aefhm aefhm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pnpm usage makes sense to me. I'm open to either resolution with regards to REF_NAME usage.

@CedarMist CedarMist merged commit 8a1f01c into main Aug 27, 2024
10 checks passed
@CedarMist CedarMist deleted the CedarMist/package-release-tags branch August 27, 2024 12:58
CedarMist added a commit that referenced this pull request Aug 27, 2024
re: #362
re: #363

for the following packages:

 * oasisprotocol/sapphire-paratime
 * oasisprotocol/sapphire-ethers-v6
 * oasisprotocol/sapphire-hardhat
 * oasisprotocol/sapphire-viem-v2
 * oasisprotocol/sapphire-wagmi-v2

They will be released under the `next` tag, to test updated publish.yaml workflow
CedarMist added a commit that referenced this pull request Aug 27, 2024
re: #362
re: #363

for the following packages:

 * oasisprotocol/sapphire-paratime
 * oasisprotocol/sapphire-ethers-v6
 * oasisprotocol/sapphire-hardhat
 * oasisprotocol/sapphire-viem-v2
 * oasisprotocol/sapphire-wagmi-v2

They will be released under the `next` tag, to test updated publish.yaml workflow
after publishing the bundlephobia links in the main README.md should work
It should also be possible to install the packages & resolve their dependencies.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
javascript Pull requests that update JavaScript code packaging
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix packaging releases, use pnpm rather than npm
3 participants