-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Viem documentation #225
Conversation
5bb22f0
to
12a1ba2
Compare
@@ -68,6 +68,44 @@ const provider = sapphire.wrap(window.ethereum); | |||
window.ethereum = sapphire.wrap(window.ethereum); // If you're feeling bold. | |||
``` | |||
|
|||
### Viem |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we keep or replicate these snippets to https://github.com/oasisprotocol/docs? Or is this okay for now? cc @matevz
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Or I have my answer in oasisprotocol/docs#585
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@CedarMist we probably want BOTH our npm user facing documentation as well as official documentation snippets right?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In addition to the npm readme, the WAGMI part should go into https://docs.oasis.io/dapp/sapphire/browser and the Viem part into https://docs.oasis.io/dapp/sapphire/quickstart or perhaps https://docs.oasis.io/dapp/sapphire/guide.
btw. Does Viem support encrypted transactions using our wrapper? I thought we only integrate with ethers hooks?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In addition to the npm readme, the WAGMI part should go into https://docs.oasis.io/dapp/sapphire/browser and the Viem part into https://docs.oasis.io/dapp/sapphire/quickstart or perhaps https://docs.oasis.io/dapp/sapphire/guide.
This sure is more convenient to reference on a PR now. 😉
Does Viem support encrypted transactions using our wrapper? I thought we only integrate with ethers hooks?
I'm able to get this through as opposed to unwrapped transaction, and I sampled these demo examples as working.
It is all EIP-1193 the way down with custom providers the way they wrap it.
8a251c8
to
fe30a74
Compare
fe30a74
to
9695ab4
Compare
This is now fairly stale and provides less support #303. |
Description
Viem has changed a bit since when we opened #164. This snippet works with Viem examples.
TODO
Vigil.sol