-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add publish workflow #203
Add publish workflow #203
Conversation
This comment was marked as duplicate.
This comment was marked as duplicate.
1 similar comment
d66d65c
to
4078153
Compare
b6f4ec1
to
0f766f3
Compare
0f766f3
to
186be4d
Compare
@CedarMist @matevz One alternative is something with more full-fledged change logs such as changesets which |
The simple github action looks easiest. |
I don't think doing releases on every main merge will work. Instead, we need to tag specific releases, and only upon tagging will that specific package get published. |
Yeah it should be based on tags, just note that in this repo we are also using tags to automatically release the runtime, so make sure to namespace the tags. |
Just clarifying that this specific GitHub action (which would run on every Can definitely switch workflow trigger to a regex based on some name-spaced tag like (Core does |
Confirming that by this we mean Git tags? I think/agree we should reserve the use of the release release for the paratime itself. Clients can just live with a trigger from simple Git tag on |
Yup so package specific tags such as:
With the Github release reserved for Sapphire releases (e.g. 0.6.4) |
59fb520
to
4af0445
Compare
4af0445
to
633d62d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Always a bit nervous about testing NPM deploys, does that mean the final test is essentially in production?
More or less 😬. I couldn't test the The one nice thing about this particular GitHub action versus writing more bare bones script is the release check, and we could always tag a patch first. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Small nit regarding the leading v
. Otherwise, I look forward to having this in oasis-sdk repo for the client-sdk/ts-web
as well! ;)
407e789
to
20e15f6
Compare
20e15f6
to
935c121
Compare
Description
Automatically publish newer versions of different JS packages to NPM if they are not present on the registry already on all pushes to the
main
branch.TODO