contracts: check constructor error handling in eth_call

contracts/contracts/tests/CreateFailCustom.sol

@@ -0,0 +1,14 @@
+// SPDX-License-Identifier: Apache-2.0
+
+pragma solidity ^0.8.0;
+
+contract CreateFailCustom {
+    uint256 constant ERROR_NUM =
+        0x1023456789abcdef1023456789abcdef1023456789abcdef1023456789abcdef;
+
+    error CustomError(uint256 value);
+
+    constructor () {
+        revert CustomError(ERROR_NUM);
+    }
+}

contracts/contracts/tests/CreateFailRequire.sol

@@ -0,0 +1,9 @@
+// SPDX-License-Identifier: Apache-2.0
+
+pragma solidity ^0.8.0;
+
+contract CreateFailRequire {
+    constructor () {
+        require(false, "ThisIsAnError");
+    }
+}

contracts/test/semantics.ts

@@ -10,7 +10,7 @@ const ERROR_NUM =
 
 describe('EVM Semantics', () => {
   let c: SemanticTests;
-  let chainId: number;
+  let chainId: bigint;
 
   before(async () => {
     const f = await ethers.getContractFactory('SemanticTests');
@@ -19,18 +19,48 @@ describe('EVM Semantics', () => {
     chainId = (await ethers.provider.getNetwork()).chainId;
   });
 
+  it('eth_call constructor with custom error', async () => {
+    const f = await ethers.getContractFactory('CreateFailCustom');
+    const tx = await f.getDeployTransaction();
+    const p = ethers.provider;
+    try {
+      const r = await p.call({
+        data: tx.data
+      });
+    } catch(x: any) {
+      expect(x.revert.args[0]).to.eq(ERROR_NUM);
+      expect(x.revert.name).to.eq('CustomError');
+    }
+  });
+
+  it('eth_call constructor with require errror', async () => {
+    const f = await ethers.getContractFactory('CreateFailRequire');
+    const tx = await f.getDeployTransaction();
+    const p = ethers.provider;
+    try {
+      const r = await p.call({
+        data: tx.data
+      });
+    } catch(x: any) {
+      expect(x.revert.args[0]).to.eq('ThisIsAnError');
+      expect(x.revert.name).to.eq('Error');
+    }
+  });
+
   it('eth_call maximum return length vs gas limit', async () => {
     const i = 1211104;
     const respHex = await c.testViewLength(i);
     const respBytes = getBytes(respHex);
     expect(respBytes.length).eq(i);
 
+    let caught = false;
     try {
       await c.testViewLength(i + 1);
-      expect(false).eq(true);
     } catch (e: any) {
+      caught = true;
       expect(e.info.error.message).contains('out of gas');
     }
+    expect(caught).eq(true);
   });
 
   it('Error string in view call', async () => {

runtime/Cargo.toml

@@ -21,8 +21,8 @@ debug = false
 keymanager = { git = "https://github.com/oasisprotocol/keymanager-paratime", tag = "v0.4.1-testnet" }
 
 # SDK.
-module-evm = { git = "https://github.com/oasisprotocol/oasis-sdk", tag = "runtime-sdk/v0.8.3", package = "oasis-runtime-sdk-evm" }
-oasis-runtime-sdk = { git = "https://github.com/oasisprotocol/oasis-sdk", tag = "runtime-sdk/v0.8.3" }
+module-evm = { git = "https://github.com/oasisprotocol/oasis-sdk", branch = "kostko/feature/evm-simulate-create", package = "oasis-runtime-sdk-evm" }
+oasis-runtime-sdk = { git = "https://github.com/oasisprotocol/oasis-sdk", branch = "kostko/feature/evm-simulate-create" }
 
 # Third party.
 once_cell = "1.8.0"

runtime/src/lib.rs

@@ -169,6 +169,7 @@ impl sdk::Runtime for Runtime {
                     max_multisig_signers: 8,
                     gas_costs: modules::core::GasCosts {
                         tx_byte: 1,
+                        storage_byte: 1,
                         auth_signature: 1_000,
                         auth_multisig_signer: 1_000,
                         callformat_x25519_deoxysii: 10_000,