Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update ROFL app docs #2109

Merged
merged 1 commit into from
Dec 12, 2024
Merged

Update ROFL app docs #2109

merged 1 commit into from
Dec 12, 2024
+16 −2

Conversation

buberdds
Copy link
Contributor

@buberdds buberdds commented Dec 12, 2024 •
edited
Loading

Tweak docs to address potential No ROFLs detected while running localstack:

  • Make sure sapphire-localnet container is not outdated
  • Commands where not clear or accurate (at least for me)
  • Adjust ports so users can access local Nexus and Explorer

@netlify Netlify
Copy link

netlify bot commented Dec 12, 2024 •
edited
Loading

✅ Deploy Preview for oasisprotocol-oasis-sdk ready!

Name Link
🔨 Latest commit 98eb36d
🔍 Latest deploy log https://app.netlify.com/sites/oasisprotocol-oasis-sdk/deploys/675af2cbac44720008ae9257
😎 Deploy Preview https://deploy-preview-2109--oasisprotocol-oasis-sdk.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

ptrus
ptrus approved these changes Dec 12, 2024
View reviewed changes
Copy link
Member

@ptrus ptrus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the updates!

docs/rofl/app.md Outdated Show resolved Hide resolved
docs/rofl/app.md Outdated Show resolved Hide resolved
@buberdds buberdds merged commit 6264f08 into main Dec 12, 2024
26 checks passed
@buberdds buberdds deleted the mz/docs branch December 12, 2024 14:52
github-actions bot added a commit that referenced this pull request Dec 12, 2024
@github-actions
Deploy js API reference Merge pull request #2109 from oasisprotocol/m…
5a7bb88 
…z/docs

Update ROFL app docs 6264f08
github-actions bot added a commit to OasisUnofficial/oasis-sdk that referenced this pull request Dec 12, 2024
@github-actions
Deploy js API reference Merge pull request oasisprotocol#2109 from oa…
85bd7aa 
…sisprotocol/mz/docs

Update ROFL app docs 6264f08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ptrus ptrus ptrus approved these changes

@kostko kostko Awaiting requested review from kostko kostko is a code owner

@pro-wh pro-wh Awaiting requested review from pro-wh pro-wh is a code owner

@peternose peternose Awaiting requested review from peternose peternose is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@buberdds @ptrus