-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
client-sdk: Add PrettyPrint to StakeThresholds #2066
Merged
Merged
+17
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matevz
requested review from
kostko,
pro-wh,
ptrus and
peternose
as code owners
November 18, 2024 14:53
✅ Deploy Preview for oasisprotocol-oasis-sdk canceled.
|
This looks ugly, why is it not |
kostko
reviewed
Nov 18, 2024
matevz
force-pushed
the
matevz/feature/stake-thresholds-prettyprint
branch
from
November 18, 2024 15:39
26cb546
to
4565a33
Compare
The idea was to resemble
But I agree, it's not readable. This should look better:
|
kostko
approved these changes
Nov 18, 2024
matevz
force-pushed
the
matevz/feature/stake-thresholds-prettyprint
branch
from
November 19, 2024 11:24
4565a33
to
ab78595
Compare
matevz
force-pushed
the
matevz/feature/stake-thresholds-prettyprint
branch
2 times, most recently
from
December 9, 2024 11:05
40ce20e
to
563856d
Compare
github-actions bot
added a commit
that referenced
this pull request
Dec 9, 2024
…atevz/feature/stake-thresholds-prettyprint client-sdk: Add PrettyPrint to StakeThresholds 7f9efcf
github-actions bot
added a commit
that referenced
this pull request
Dec 9, 2024
…/matevz/feature/stake-thresholds-prettyprint client-sdk: Add PrettyPrint to StakeThresholds 7f9efcf
github-actions bot
added a commit
to OasisUnofficial/oasis-sdk
that referenced
this pull request
Dec 9, 2024
…sisprotocol/matevz/feature/stake-thresholds-prettyprint client-sdk: Add PrettyPrint to StakeThresholds 7f9efcf
github-actions bot
added a commit
to OasisUnofficial/oasis-sdk
that referenced
this pull request
Dec 9, 2024
…oasisprotocol/matevz/feature/stake-thresholds-prettyprint client-sdk: Add PrettyPrint to StakeThresholds 7f9efcf
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements
PrettyPrint()
forStakeThresholds
. Improves output of oasisprotocol/cli#318 to