-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Dockerfile for developing ROFL #2063
base: main
Are you sure you want to change the base?
Conversation
❌ Deploy Preview for oasisprotocol-oasis-sdk failed.
|
0cf620f
to
0554b1b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'll make another pass once Oasis CLI 0.10.3+ is released.
the next section of this guide: | ||
|
||
```bash | ||
docker run --platform linux/amd64 --volume ./rofl-oracle:/src -it ghcr.io/oasisprotocol/rofl-dev |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This command could actually be expanded in the application.md chapter to include full build commands.
@@ -0,0 +1,9 @@ | |||
FROM ghcr.io/oasisprotocol/oasis-core-dev:stable-24.3.x AS oasis-core-dev | |||
|
|||
ARG OASIS_CLI_VERSION=0.10.3 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Related to oasisprotocol/cli#319
docs/rofl/prerequisites.md
Outdated
you can install those by running: | ||
|
||
```shell | ||
sudo apt install musl-tools gcc-multilib clang | ||
sudo apt install gcc-multilib clang |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Note: when trying to run it in ubuntu docker (and devcontainer), it also required:
sudo apt update
sudo apt -y install pkg-config protobuf-compiler cmake
dfe9879
to
5ffd4cd
Compare
5ffd4cd
to
4e6fcc3
Compare
4e6fcc3
to
2f9396e
Compare
I noticed I needed |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please address the issues. Otherwise lgtm. Merge oasisprotocol/docs#1042 first to unblock the CI.
```shell | ||
oasis rofl build sgx --mode unsafe | ||
``` | ||
2. Compile ROFL in the _unsafe_ mode. If you're using the `rofl-dev` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
2. Compile ROFL in the _unsafe_ mode. If you're using the `rofl-dev` | |
2. Compile ROFL in the _unsafe_ mode. If you're using the [`rofl-dev`] |
And somewhere at the end of the section:
[`rofl-dev`]: https://github.com/oasisprotocol/oasis-sdk/pkgs/container/rofl-dev
</TabItem> | ||
<TabItem value="rofl-dev" label="Container"> | ||
```shell | ||
docker run --platform linux/amd64 --volume ./rofl-oracle:/src -it ghcr.io/oasisprotocol/rofl-dev oasis rofl build sgx --mode unsafe |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think the current path is the rofl-oracle root already.
docker run --platform linux/amd64 --volume ./rofl-oracle:/src -it ghcr.io/oasisprotocol/rofl-dev oasis rofl build sgx --mode unsafe | |
docker run --platform linux/amd64 --volume .:/src -it ghcr.io/oasisprotocol/rofl-dev oasis rofl build sgx --mode unsafe |
Also change the docker command in the next step.
@@ -0,0 +1,11 @@ | |||
FROM ghcr.io/oasisprotocol/oasis-core-dev:stable-24.3.x AS oasis-core-dev | |||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See #2063 (comment)
ENV RUSTFLAGS="-C target-feature=+aes,+ssse3" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
^^ Please test if this works. (remove .cargo folder and see if ROFL still compiles)
No description provided.