client-sdk/go: Migrate ResolveAddress to Oasis CLI #1614
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matevz
requested review from
kostko,
pro-wh,
ptrus and
peternose
as code owners
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1614 +/- ##
==========================================
- Coverage 61.47% 61.23% -0.24%
==========================================
Files 139 139
Lines 9907 9865 -42
==========================================
- Hits 6090 6041 -49
- Misses 3775 3780 +5
- Partials 42 44 +2 ☔ View full report in Codecov by Sentry. |
kostko
approved these changes
Jan 25, 2024
matevz
force-pushed
the
matevz/feature/migrate-resolveaddress
branch
3 times, most recently
from
44cf1e5 to
0534aa4
Compare
matevz
force-pushed
the
matevz/feature/migrate-resolveaddress
branch
from
0534aa4 to
4dc4b80
Compare
github-actions bot
added a commit
that referenced
this pull request
Jan 26, 2024
…atevz/feature/migrate-resolveaddress client-sdk/go: Migrate ResolveAddress to Oasis CLI cebc818
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR:
ResolveAddress()helper which was moved to Oasis CLI (cmd/wallet: More reserved addresses aliases and checks cli#134)ResolveEthOrOasisAddress()Merge after oasisprotocol/cli#134 and when the
runtime-sdk/v0.8.4tag is pushed after #1507