Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

runtime-sdk: bump crypto deps #1518

Merged
merged 3 commits into from
Oct 4, 2023
Merged

runtime-sdk: bump crypto deps #1518

merged 3 commits into from
Oct 4, 2023

Conversation

nhynes
Copy link
Contributor

@nhynes nhynes commented Oct 3, 2023

I had some trouble getting p384 working because sha2, ed25519_dalek, and a few other crypto deps were a version behind. Such is the state of Rust crypto. Anyway, this PR does not change any functionality, but I did remove one test for rejecting all-zero ed25519 private keys because [0u8; 32] is a valid private key, just not one you'd want to use.

@codecov
Copy link

codecov bot commented Oct 3, 2023

Codecov Report

Merging #1518 (a700acf) into main (7d979b9) will increase coverage by 1.45%.
The diff coverage is 82.14%.

@@            Coverage Diff             @@
##             main    #1518      +/-   ##
==========================================
+ Coverage   59.03%   60.49%   +1.45%     
==========================================
  Files         138      138              
  Lines        9874     9904      +30     
==========================================
+ Hits         5829     5991     +162     
+ Misses       4003     3871     -132     
  Partials       42       42              
Files Coverage Δ
contract-sdk/crypto/src/x25519.rs 94.44% <100.00%> (ø)
runtime-sdk/modules/evm/src/precompile/sha512.rs 100.00% <100.00%> (ø)
runtime-sdk/src/crypto/signature/digests.rs 20.83% <ø> (+0.32%) ⬆️
runtime-sdk/src/crypto/signature/mod.rs 71.87% <100.00%> (ø)
runtime-sdk/src/storage/confidential.rs 72.13% <ø> (ø)
runtime-sdk/src/crypto/signature/sr25519.rs 36.84% <0.00%> (ø)
...ime-sdk/modules/evm/src/precompile/confidential.rs 80.32% <33.33%> (-1.10%) ⬇️
runtime-sdk/src/crypto/signature/ed25519.rs 84.21% <85.10%> (-2.94%) ⬇️

... and 2 files with indirect coverage changes

@nhynes nhynes force-pushed the nhynes/bump-crypto-deps branch from 8de253d to 922332d Compare October 3, 2023 15:54
@nhynes nhynes force-pushed the nhynes/bump-crypto-deps branch 2 times, most recently from 495f5b6 to aa4c87b Compare October 3, 2023 20:29
@nhynes nhynes force-pushed the nhynes/bump-crypto-deps branch from aa4c87b to bc35522 Compare October 3, 2023 20:33
runtime-sdk/src/crypto/signature/ed25519.rs Outdated Show resolved Hide resolved
runtime-sdk/src/crypto/signature/ed25519.rs Outdated Show resolved Hide resolved
runtime-sdk/src/crypto/signature/ed25519.rs Outdated Show resolved Hide resolved
@nhynes nhynes force-pushed the nhynes/bump-crypto-deps branch from bc35522 to 4dc1196 Compare October 4, 2023 12:34
@nhynes nhynes requested review from kostko and peternose October 4, 2023 12:34
@nhynes nhynes force-pushed the nhynes/bump-crypto-deps branch 2 times, most recently from de01f21 to 1d45270 Compare October 4, 2023 16:33
@nhynes nhynes force-pushed the nhynes/bump-crypto-deps branch from 1d45270 to a700acf Compare October 4, 2023 16:34
@nhynes nhynes requested a review from kostko October 4, 2023 16:58
@nhynes nhynes merged commit 11e1d6f into main Oct 4, 2023
27 checks passed
@nhynes nhynes deleted the nhynes/bump-crypto-deps branch October 4, 2023 19:39
github-actions bot added a commit that referenced this pull request Oct 4, 2023
…hynes/bump-crypto-deps

runtime-sdk: bump crypto deps 11e1d6f
github-actions bot added a commit that referenced this pull request Oct 4, 2023
…/nhynes/bump-crypto-deps

runtime-sdk: bump crypto deps 11e1d6f
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants