-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
runtime-sdk: bump crypto deps #1518
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nhynes
requested review from
kostko,
pro-wh,
ptrus and
peternose
as code owners
October 3, 2023 15:49
Codecov Report
@@ Coverage Diff @@
## main #1518 +/- ##
==========================================
+ Coverage 59.03% 60.49% +1.45%
==========================================
Files 138 138
Lines 9874 9904 +30
==========================================
+ Hits 5829 5991 +162
+ Misses 4003 3871 -132
Partials 42 42
|
nhynes
force-pushed
the
nhynes/bump-crypto-deps
branch
from
October 3, 2023 15:54
8de253d
to
922332d
Compare
kostko
reviewed
Oct 3, 2023
nhynes
force-pushed
the
nhynes/bump-crypto-deps
branch
2 times, most recently
from
October 3, 2023 20:29
495f5b6
to
aa4c87b
Compare
nhynes
commented
Oct 3, 2023
nhynes
force-pushed
the
nhynes/bump-crypto-deps
branch
from
October 3, 2023 20:33
aa4c87b
to
bc35522
Compare
peternose
reviewed
Oct 4, 2023
nhynes
force-pushed
the
nhynes/bump-crypto-deps
branch
from
October 4, 2023 12:34
bc35522
to
4dc1196
Compare
kostko
reviewed
Oct 4, 2023
nhynes
force-pushed
the
nhynes/bump-crypto-deps
branch
2 times, most recently
from
October 4, 2023 16:33
de01f21
to
1d45270
Compare
nhynes
force-pushed
the
nhynes/bump-crypto-deps
branch
from
October 4, 2023 16:34
1d45270
to
a700acf
Compare
kostko
approved these changes
Oct 4, 2023
github-actions bot
added a commit
that referenced
this pull request
Oct 4, 2023
…hynes/bump-crypto-deps runtime-sdk: bump crypto deps 11e1d6f
github-actions bot
added a commit
that referenced
this pull request
Oct 4, 2023
…/nhynes/bump-crypto-deps runtime-sdk: bump crypto deps 11e1d6f
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I had some trouble getting
p384
working becausesha2
,ed25519_dalek
, and a few other crypto deps were a version behind. Such is the state of Rust crypto. Anyway, this PR does not change any functionality, but I did remove one test for rejecting all-zero ed25519 private keys because[0u8; 32]
is a valid private key, just not one you'd want to use.