Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

runtime-sdk: support dynamic min-gas-price #1514

Merged
merged 1 commit into from
Oct 3, 2023

Conversation

ptrus
Copy link
Member

@ptrus ptrus commented Sep 27, 2023

Adds support for dynamic min gas price inspired by EIP-1559

@codecov
Copy link

codecov bot commented Sep 27, 2023

Codecov Report

Merging #1514 (cd68f35) into main (9e8c6e9) will increase coverage by 0.06%.
The diff coverage is 73.13%.

@@            Coverage Diff             @@
##             main    #1514      +/-   ##
==========================================
+ Coverage   60.34%   60.41%   +0.06%     
==========================================
  Files         138      138              
  Lines        9840     9894      +54     
==========================================
+ Hits         5938     5977      +39     
- Misses       3860     3875      +15     
  Partials       42       42              
Files Coverage Δ
runtime-sdk/modules/evm/src/precompile/testing.rs 80.59% <100.00%> (+0.29%) ⬆️
runtime-sdk/src/dispatcher.rs 18.50% <ø> (ø)
runtime-sdk/modules/evm/src/backend.rs 70.00% <0.00%> (ø)
runtime-sdk/src/modules/core/mod.rs 72.77% <73.84%> (-0.17%) ⬇️

@ptrus ptrus force-pushed the ptrus/feature/dynamic-min-gas-price branch 5 times, most recently from e10c718 to fae44b9 Compare September 28, 2023 17:16
Copy link
Member

@kostko kostko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this looks right, just some nits and comments around handling of edge cases (would be good to have tests for those as well).

runtime-sdk/src/modules/core/mod.rs Outdated Show resolved Hide resolved
runtime-sdk/src/modules/core/mod.rs Outdated Show resolved Hide resolved
runtime-sdk/src/modules/core/mod.rs Outdated Show resolved Hide resolved
runtime-sdk/src/modules/core/mod.rs Outdated Show resolved Hide resolved
runtime-sdk/src/modules/core/mod.rs Show resolved Hide resolved
runtime-sdk/src/modules/core/mod.rs Outdated Show resolved Hide resolved
runtime-sdk/src/modules/core/mod.rs Outdated Show resolved Hide resolved
runtime-sdk/src/modules/core/mod.rs Outdated Show resolved Hide resolved
@ptrus ptrus force-pushed the ptrus/feature/dynamic-min-gas-price branch 7 times, most recently from 6aba65a to 7e8c871 Compare September 29, 2023 14:43
@ptrus ptrus marked this pull request as ready for review September 29, 2023 15:35
runtime-sdk/src/modules/core/mod.rs Outdated Show resolved Hide resolved
runtime-sdk/src/modules/core/mod.rs Outdated Show resolved Hide resolved
runtime-sdk/src/modules/core/mod.rs Outdated Show resolved Hide resolved
@ptrus ptrus force-pushed the ptrus/feature/dynamic-min-gas-price branch from 7e8c871 to cd68f35 Compare October 3, 2023 05:15
@ptrus ptrus merged commit 7d979b9 into main Oct 3, 2023
27 checks passed
@ptrus ptrus deleted the ptrus/feature/dynamic-min-gas-price branch October 3, 2023 13:05
github-actions bot added a commit that referenced this pull request Oct 3, 2023
…trus/feature/dynamic-min-gas-price

runtime-sdk: support dynamic min-gas-price 7d979b9
github-actions bot added a commit that referenced this pull request Oct 3, 2023
…/ptrus/feature/dynamic-min-gas-price

runtime-sdk: support dynamic min-gas-price 7d979b9
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants