-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
runtime-sdk: support dynamic min-gas-price #1514
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #1514 +/- ##
==========================================
+ Coverage 60.34% 60.41% +0.06%
==========================================
Files 138 138
Lines 9840 9894 +54
==========================================
+ Hits 5938 5977 +39
- Misses 3860 3875 +15
Partials 42 42
|
ptrus
force-pushed
the
ptrus/feature/dynamic-min-gas-price
branch
5 times, most recently
from
September 28, 2023 17:16
e10c718
to
fae44b9
Compare
kostko
reviewed
Sep 29, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this looks right, just some nits and comments around handling of edge cases (would be good to have tests for those as well).
ptrus
force-pushed
the
ptrus/feature/dynamic-min-gas-price
branch
7 times, most recently
from
September 29, 2023 14:43
6aba65a
to
7e8c871
Compare
kostko
reviewed
Oct 2, 2023
ptrus
force-pushed
the
ptrus/feature/dynamic-min-gas-price
branch
from
October 3, 2023 05:15
7e8c871
to
cd68f35
Compare
kostko
approved these changes
Oct 3, 2023
github-actions bot
added a commit
that referenced
this pull request
Oct 3, 2023
…trus/feature/dynamic-min-gas-price runtime-sdk: support dynamic min-gas-price 7d979b9
github-actions bot
added a commit
that referenced
this pull request
Oct 3, 2023
…/ptrus/feature/dynamic-min-gas-price runtime-sdk: support dynamic min-gas-price 7d979b9
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds support for dynamic min gas price inspired by EIP-1559