Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

runtime-sdk/modules/evm: Drop signed queries in new contracts #1481

Merged
merged 2 commits into from
Sep 18, 2023

Conversation

kostko
Copy link
Member

@kostko kostko commented Sep 11, 2023

TODO

  • More tests.

@kostko kostko added the m:evm Module: evm label Sep 11, 2023
@codecov
Copy link

codecov bot commented Sep 11, 2023

Codecov Report

Merging #1481 (75870b3) into main (b178b66) will increase coverage by 0.72%.
The diff coverage is 74.02%.

@@            Coverage Diff             @@
##             main    #1481      +/-   ##
==========================================
+ Coverage   59.51%   60.24%   +0.72%     
==========================================
  Files         138      138              
  Lines        9631     9707      +76     
==========================================
+ Hits         5732     5848     +116     
+ Misses       3857     3817      -40     
  Partials       42       42              
Files Changed Coverage Δ
runtime-sdk/modules/evm/src/backend.rs 69.95% <66.66%> (-0.05%) ⬇️
runtime-sdk/modules/evm/src/lib.rs 64.20% <66.66%> (+20.59%) ⬆️
runtime-sdk/modules/evm/src/types.rs 66.66% <66.66%> (ø)
runtime-sdk/modules/evm/src/mock.rs 80.24% <70.21%> (-10.93%) ⬇️
runtime-sdk/src/testing/mock.rs 87.30% <80.00%> (-0.63%) ⬇️
runtime-sdk/modules/evm/src/state.rs 93.10% <100.00%> (+1.43%) ⬆️

... and 1 file with indirect coverage changes

@kostko kostko force-pushed the kostko/feature/evm-drop-signed-queries branch from bbbde0f to 5ea40a7 Compare September 13, 2023 12:09
@kostko kostko changed the base branch from main to kostko/feature/module-migrations-derive September 13, 2023 12:10
@kostko kostko force-pushed the kostko/feature/module-migrations-derive branch 2 times, most recently from f6a1e31 to d4c34bc Compare September 13, 2023 13:27
@kostko kostko force-pushed the kostko/feature/evm-drop-signed-queries branch from a600d4c to 3186a88 Compare September 13, 2023 13:28
@kostko kostko force-pushed the kostko/feature/module-migrations-derive branch from d4c34bc to 3a9efd6 Compare September 13, 2023 13:43
@kostko kostko force-pushed the kostko/feature/evm-drop-signed-queries branch from 3186a88 to 2402d78 Compare September 13, 2023 13:44
@kostko kostko force-pushed the kostko/feature/module-migrations-derive branch from 3a9efd6 to a66d706 Compare September 14, 2023 11:43
Base automatically changed from kostko/feature/module-migrations-derive to main September 14, 2023 12:28
@kostko kostko force-pushed the kostko/feature/evm-drop-signed-queries branch 2 times, most recently from 92ce19b to 369c8e8 Compare September 14, 2023 13:18
@kostko kostko marked this pull request as ready for review September 14, 2023 13:20
@kostko kostko force-pushed the kostko/feature/evm-drop-signed-queries branch from 369c8e8 to 4b24ab4 Compare September 14, 2023 13:36
@kostko kostko force-pushed the kostko/feature/evm-drop-signed-queries branch from 4b24ab4 to 75870b3 Compare September 15, 2023 06:57
@kostko kostko merged commit 998adda into main Sep 18, 2023
27 checks passed
@kostko kostko deleted the kostko/feature/evm-drop-signed-queries branch September 18, 2023 09:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
m:evm Module: evm
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants