Merge pull request #1885 from oasisprotocol/kostko/feature/rofl-less-…

…coupling runtime-sdk/modules/rofl: Require consensus trust root implementation
oasisprotocol · Jul 16, 2024 · 1ddb024 · 1ddb024
2 parents b4feedd + d7c569a
commit 1ddb024
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 3 deletions.
diff --git a/runtime-sdk/src/modules/rofl/app/mod.rs b/runtime-sdk/src/modules/rofl/app/mod.rs
@@ -39,9 +39,7 @@ pub trait App: Send + Sync + 'static {
 
     /// Return the consensus layer trust root for this runtime; if `None`, consensus layer integrity
     /// verification will not be performed.
-    fn consensus_trust_root() -> Option<TrustRoot> {
-        None
-    }
+    fn consensus_trust_root() -> Option<TrustRoot>;
 
     /// Create a new unsigned transaction.
     fn new_transaction<B>(&self, method: &str, body: B) -> transaction::Transaction

diff --git a/tests/runtimes/components-rofl/src/main.rs b/tests/runtimes/components-rofl/src/main.rs
@@ -5,6 +5,7 @@ use async_trait::async_trait;
 
 use oasis_runtime_sdk::{
     self as sdk,
+    core::consensus::verifier::TrustRoot,
     modules::rofl::app::{App, AppId, Environment},
     Version,
 };
@@ -25,6 +26,12 @@ impl App for TestApp {
         *components_ronl::EXAMPLE_APP_ID
     }
 
+    /// Return the consensus layer trust root for this runtime; if `None`, consensus layer integrity
+    /// verification will not be performed.
+    fn consensus_trust_root() -> Option<TrustRoot> {
+        None // Production apps should never use `None` as this is unsafe.
+    }
+
     async fn run(self: Arc<Self>, _env: Environment<Self>) {
         // We are running now!
         println!("Hello ROFL world!");