account: provide delegations_to instead #348
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pro-wh
requested review from
abukosek,
kostko,
peterjgilbert and
tjanez
as code owners
oasis-node does not handle GetDelegations efficiently. This changes the gateway to use GetDelegationsTo, which the node can answer efficiently.
pro-wh
force-pushed
the
pro-wh/feature/delegations
branch
from
05e129b
to
9eef5f7
Compare
|
sad note: one of the gateways we use times out trying to get delegations from, so at least we know that nothing is usefully relying on it 😬 |
|
"delegations to" is not efficient either. converting this to draft |
|
oasisprotocol/oasis-core#5023 with any luck, we'll have efficient DelegationsFor in the same timeframe, so we won't have to merge this change |
|
this is now quite fast in 23.0.x |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
oasis-node does not handle GetDelegations efficiently. This changes
the gateway to use GetDelegationsTo, which the node can answer
efficiently.
ok and from #61/#62, it seems we didn't specifically want delegations from, and the issue looks like it was written to call for either of them. at this point, we know that the node software can much more easily list delegations to an account and debonding delegations "from" an account, so I'm proposing that we move to those.
for users relying on the previous delegations "from" behavior, you'll have to stay on the 2.x.x stable branches, and we should maintain that for some amount of time.
I intend for us to upgrade any of our own deployments to include this change.
fixes #347