Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

backport: go/consensus/tendermint: Properly cache consensus parameters #2713

Merged
merged 4 commits into from
Feb 24, 2020

Conversation

kostko
Copy link
Member

@kostko kostko commented Feb 24, 2020

Backport of fix for #2708 (from #2709).

Also backports some fixes that are required for the new CI pipeline.

tjanez and others added 3 commits February 24, 2020 13:24
Use Buildkite's dynamic pipelines feature to dynamically choose between
Code/Code-skip pipelines depending on whether the build was triggered
for a pull request and the list of changes files.
@codecov
Copy link

codecov bot commented Feb 24, 2020

Codecov Report

Merging #2713 into stable/20.3.x will decrease coverage by 0.18%.
The diff coverage is n/a.

Impacted file tree graph

@@                Coverage Diff                @@
##           stable/20.3.x    #2713      +/-   ##
=================================================
- Coverage          62.96%   62.77%   -0.19%     
=================================================
  Files                365      365              
  Lines              34396    34411      +15     
=================================================
- Hits               21658    21603      -55     
- Misses             10061    10139      +78     
+ Partials            2677     2669       -8     
Impacted Files Coverage Δ
go/worker/common/host/sandboxed.go 70.22% <0.00%> (-5.75%) ⬇️
go/oasis-node/cmd/debug/byzantine/byzantine.go 35.01% <0.00%> (-5.04%) ⬇️
go/worker/common/host/protocol/protocol.go 65.67% <0.00%> (-2.99%) ⬇️
go/worker/common/p2p/p2p.go 64.86% <0.00%> (-2.71%) ⬇️
go/oasis-node/cmd/debug/byzantine/merge.go 74.68% <0.00%> (-2.54%) ⬇️
go/common/grpc/grpc.go 77.59% <0.00%> (-1.25%) ⬇️
go/worker/compute/txnscheduler/committee/node.go 61.39% <0.00%> (-0.64%) ⬇️
go/worker/registration/worker.go 67.24% <0.00%> (-0.50%) ⬇️
go/worker/compute/executor/committee/node.go 62.45% <0.00%> (-0.40%) ⬇️
go/worker/compute/merge/committee/node.go 76.25% <0.00%> (-0.25%) ⬇️
... and 3 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cef4925...61008df. Read the comment docs.

@kostko kostko merged commit b5eec74 into stable/20.3.x Feb 24, 2020
@kostko kostko deleted the kostko/backport/consensus-params-cache-fix branch February 24, 2020 12:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants