This repository has been archived by the owner on May 5, 2021. It is now read-only.
internal/ge25519: Use the unsafe moveConditionalBytes on more targets #19
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Instead of only using the subtle.ConstantTimeCopy replacement on architectures that are indifferent to alignment, check to see if the arguments are well-aligned, and use the faster path if possible. This is primarily for the benefit of ARM systems, where this will improve the key generation and signing performance by up to 30%.
3 tasks
kostko
approved these changes
Feb 6, 2020
|
@target111, @iwasaki-kenta This may be of interest to one or both of you, as it dramatically improves key generation and signing performance on ARM targets. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of only using the subtle.ConstantTimeCopy replacement on
architectures that are indifferent to alignment, check to see if
the arguments are well-aligned, and use the faster path if possible.
This is primarily for the benefit of ARM systems, where this will
improve the key generation and signing performance by up to 30%.
Part of #18.