Handle repeated AddToMetaMask clicks #869
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for oasisprotocol-docs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
matevz
approved these changes
Jul 5, 2024
src/AddToMetaMask.tsx
Outdated
| @@ -33,6 +33,8 @@ const AddToMetaMask = (props: { | |||
| blockExplorerUrls: props.be, | |||
| }, | |||
| ], | |||
| }).then(response => { | |||
| if (response === null) alert('Added') | |||
There was a problem hiding this comment.
Can you change the alert to something like:
The RPC endpoint for Chain ID {props.chainId} already exists.
If you want to replace it, please remove the old RPC endpoint first and then add the new one.
Suggested change
| if (response === null) alert('Added') | |
| if (response === null) alert('Added') |
There was a problem hiding this comment.
- This message is shown when you first add Sapphire too. We would need to measure how quickly null is returned to differentiate "already exists" vs "added first time".
- If you have OPF sapphire RPC added and you click 1RPC: metamask will ask you if you want to add 1RPC as a separate entry. No need to remove first. (if we really wanted to, I guess we could detect any existing entries with wallet_switchEthereumChain)
matevz
approved these changes
Jul 8, 2024
lukaw3d
force-pushed
the
lw/repeated-add-to-metamask
branch
2 times, most recently
from
2a43fa7 to
fa63772
Compare
lukaw3d
force-pushed
the
lw/repeated-add-to-metamask
branch
from
fa63772 to
55f352e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If user already has a chain added in metamask, then button does nothing. Added a message
Before, After:
before.after.webm