Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs/node/validator: Update config file for 23.0 #640

Merged
merged 1 commit into from
Nov 28, 2023

Conversation

amela
Copy link
Member

@amela amela commented Nov 27, 2023

@amela amela requested a review from kostko November 27, 2023 18:13
Copy link

netlify bot commented Nov 27, 2023

Deploy Preview for trusting-archimedes-14c863 ready!

Name Link
🔨 Latest commit d0693b9
🔍 Latest deploy log https://app.netlify.com/sites/trusting-archimedes-14c863/deploys/65664b09075d7d000895e173
😎 Deploy Preview https://deploy-preview-640--trusting-archimedes-14c863.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@amela amela force-pushed the amela/update-validator-config-for-23.0 branch 2 times, most recently from f6bbf9a to 1e1b131 Compare November 28, 2023 08:37
@amela amela requested a review from ptrus November 28, 2023 11:12
@amela amela force-pushed the amela/update-validator-config-for-23.0 branch from 1e1b131 to 188d19b Compare November 28, 2023 11:43
@amela
Copy link
Member Author

amela commented Nov 28, 2023

Re-added comments

Comment on lines 197 to 200
# By default logs are output to stdout. If you would like to output
# logs to a file, you can use:
#
# file: /var/log/oasis-node.log
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This part should be unindented and to make it more clear the keys should be ordered as in the old config, e.g. level, format, file.

@amela amela force-pushed the amela/update-validator-config-for-23.0 branch from 188d19b to b570e8f Compare November 28, 2023 18:45
@amela amela requested a review from kostko November 28, 2023 18:46
@amela amela force-pushed the amela/update-validator-config-for-23.0 branch from b570e8f to a2f545e Compare November 28, 2023 20:16
@amela amela force-pushed the amela/update-validator-config-for-23.0 branch from a2f545e to d0693b9 Compare November 28, 2023 20:18
@amela amela enabled auto-merge November 28, 2023 20:19
@amela amela merged commit a518535 into main Nov 28, 2023
2 checks passed
@amela amela deleted the amela/update-validator-config-for-23.0 branch November 28, 2023 20:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants