docs/node: Fix link to Oasis Cli #613
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for trusting-archimedes-14c863 ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
kostko
approved these changes
Nov 15, 2023
matevz
requested changes
Nov 15, 2023
docs/node/mainnet/eden-upgrade.md
Outdated
| @@ -209,7 +209,7 @@ Ubuntu versions (or other distributions using older system libraries). | |||
|
|
|||
| 11. Start your node and re-enable auto-starting via your process manager. | |||
|
|
|||
| [Oasis CLI]: ../../general/manage-tokens/cli/ | |||
| [Oasis CLI]: ../../../general/manage-tokens/cli/ | |||
There was a problem hiding this comment.
That seems wrong 🤔
This should work:
Suggested change
| [Oasis CLI]: ../../../general/manage-tokens/cli/ | |
| [Oasis CLI]: ../../general/manage-tokens/cli/README.md |
There was a problem hiding this comment.
But ../../../general/manage-tokens/cli/ works on the preview: https://deploy-preview-613--trusting-archimedes-14c863.netlify.app/node/mainnet/eden-upgrade
There was a problem hiding this comment.
Referencing the markdown files instead of URLs is a better idea because it's easier to refactor, links will also work in Github and various IDEs.
There was a problem hiding this comment.
Also ../../general/manage-tokens/cli/README.md will go to https://docs.oasis.io/node/general/manage-tokens/cli/README.md that does not exists.
amela
force-pushed
the
amela/fix-link-to-cli
branch
from
618aec6 to
a3a77a2
Compare
matevz
approved these changes
Nov 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.