Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace oasis-node with oasis in the Run node part #588

Merged
merged 10 commits into from
Nov 20, 2023

Conversation

matevz
Copy link
Member

@matevz matevz commented Oct 20, 2023

Updates "Run Node" section so that we don't use oasis-node registry and other deprecated commands anymore:

  • uses oasis for generating the entity and submitting it by completely revamping the Entity generation and the usage of Ledger in the Validator node chapter
  • replaces deprecated oasis-node registry command with oasis network show in a handful of chapters
  • replaces /serverdir/ organization with /node/. See Replace oasis-node with oasis in the Run node part #588 (comment)
  • fixes some typos and wrong URLs in key-manager-upgrade, how-to-transfer-rose-into-paratime and ledger-wallet chapters
  • adds the usage of the Oasis CLI, Mainnet and Testnet terms to the Vocabulary section in README

Fixes #505

Note: sentry-node, maintenance/install-oasis-remote-signer-binary will be updated in #615 since they require thorough config changes and explicit registry node init won't be needed anymore.

Preview

@netlify
Copy link

netlify bot commented Oct 20, 2023

Deploy Preview for trusting-archimedes-14c863 ready!

Name Link
🔨 Latest commit 0e03196
🔍 Latest deploy log https://app.netlify.com/sites/trusting-archimedes-14c863/deploys/655b67e6e30cfc00080c4db5
😎 Deploy Preview https://deploy-preview-588--trusting-archimedes-14c863.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@matevz matevz force-pushed the matevz/docs/run-node-replace-oasis-node-with-oasis branch 3 times, most recently from 3f6ca41 to ab3375b Compare November 14, 2023 13:42
@matevz matevz requested review from kostko and gw0 November 14, 2023 15:14
@matevz matevz marked this pull request as ready for review November 14, 2023 15:14
@matevz matevz force-pushed the matevz/docs/run-node-replace-oasis-node-with-oasis branch from 9cac492 to 1944849 Compare November 14, 2023 15:19
docs/node/run-your-node/validator-node.mdx Outdated Show resolved Hide resolved
docs/node/run-your-node/validator-node.mdx Outdated Show resolved Hide resolved
docs/node/run-your-node/validator-node.mdx Outdated Show resolved Hide resolved
docs/node/run-your-node/validator-node.mdx Outdated Show resolved Hide resolved
docs/node/run-your-node/validator-node.mdx Outdated Show resolved Hide resolved
docs/node/run-your-node/validator-node.mdx Outdated Show resolved Hide resolved
docs/node/run-your-node/validator-node.mdx Outdated Show resolved Hide resolved
@matevz matevz force-pushed the matevz/docs/run-node-replace-oasis-node-with-oasis branch 2 times, most recently from 20941c4 to 1e8518b Compare November 15, 2023 11:44
Copy link
Contributor

@gw0 gw0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A couple of suggestions...

docs/node/run-your-node/validator-node.mdx Outdated Show resolved Hide resolved
docs/node/run-your-node/validator-node.mdx Outdated Show resolved Hide resolved
docs/node/run-your-node/validator-node.mdx Outdated Show resolved Hide resolved
docs/node/run-your-node/validator-node.mdx Outdated Show resolved Hide resolved
docs/node/run-your-node/validator-node.mdx Outdated Show resolved Hide resolved
docs/node/run-your-node/validator-node.mdx Outdated Show resolved Hide resolved
docs/node/run-your-node/validator-node.mdx Show resolved Hide resolved
docs/node/run-your-node/validator-node.mdx Outdated Show resolved Hide resolved
docs/node/run-your-node/validator-node.mdx Outdated Show resolved Hide resolved
docs/node/run-your-node/validator-node.mdx Outdated Show resolved Hide resolved
@matevz matevz force-pushed the matevz/docs/run-node-replace-oasis-node-with-oasis branch from 1e8518b to 817805e Compare November 16, 2023 12:08
Copy link
Contributor

@gw0 gw0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some more feedback... This refactoring is a great opportunity to standardize the server-side directories to /node/{etc,bin,runtimes,data}.

docs/node/run-your-node/validator-node.mdx Outdated Show resolved Hide resolved
docs/node/run-your-node/validator-node.mdx Outdated Show resolved Hide resolved
docs/node/run-your-node/validator-node.mdx Show resolved Hide resolved
docs/node/run-your-node/validator-node.mdx Outdated Show resolved Hide resolved
docs/node/run-your-node/validator-node.mdx Outdated Show resolved Hide resolved
docs/node/run-your-node/validator-node.mdx Outdated Show resolved Hide resolved
docs/node/run-your-node/validator-node.mdx Outdated Show resolved Hide resolved
docs/node/run-your-node/validator-node.mdx Outdated Show resolved Hide resolved
@matevz matevz force-pushed the matevz/docs/run-node-replace-oasis-node-with-oasis branch 2 times, most recently from ade16e7 to 0a60b07 Compare November 17, 2023 18:06
@matevz matevz requested a review from gw0 November 17, 2023 18:09
@matevz matevz force-pushed the matevz/docs/run-node-replace-oasis-node-with-oasis branch from 0a60b07 to f62a6cc Compare November 17, 2023 18:12
Copy link
Contributor

@gw0 gw0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome! A few more suggestions from my side.

@matevz matevz force-pushed the matevz/docs/run-node-replace-oasis-node-with-oasis branch from f62a6cc to e32066a Compare November 20, 2023 13:52
@matevz matevz merged commit 90b3903 into main Nov 20, 2023
6 checks passed
@matevz matevz deleted the matevz/docs/run-node-replace-oasis-node-with-oasis branch November 20, 2023 16:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Replace oasis-node with Oasis CLI in Run Node chapter
3 participants