Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: move verification to tools #1054

Merged
merged 1 commit into from
Dec 13, 2024
Merged

docs: move verification to tools #1054

merged 1 commit into from
Dec 13, 2024

Conversation

rube-de
Copy link
Contributor

@rube-de rube-de commented Dec 12, 2024 •
edited
Loading

  • new verification chapter under tools
  • add section for hardhat
  • add section for foundry
  • moved manual verification to the bottom
  • add troubleshooting section
  • added redirect

PREVIEW

@rube-de rube-de linked an issue Dec 12, 2024 that may be closed by this pull request
Move contract verification from Sapphire to Tools #1029
Closed
@rube-de rube-de requested review from aefhm and matevz December 12, 2024 19:04
@netlify Netlify
Copy link

netlify bot commented Dec 12, 2024 •
edited
Loading

✅ Deploy Preview for oasisprotocol-docs ready!

Name Link
🔨 Latest commit 48baba1
🔍 Latest deploy log https://app.netlify.com/sites/oasisprotocol-docs/deploys/675b41a339f470000818bcf3
😎 Deploy Preview https://deploy-preview-1054--oasisprotocol-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@rube-de rube-de mentioned this pull request Dec 12, 2024
Merged
@rube-de rube-de self-assigned this Dec 12, 2024
@rube-de rube-de added the documentation Improvements or additions to documentation label Dec 12, 2024
aefhm
aefhm approved these changes Dec 12, 2024
View reviewed changes
Copy link
Contributor

@aefhm aefhm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Non-blocking comments.

docs/dapp/tools/verification.md Outdated Show resolved Hide resolved
docs/dapp/tools/verification.md Outdated Show resolved Hide resolved
docs/dapp/tools/verification.md Outdated Show resolved Hide resolved
@rube-de rube-de force-pushed the 1029-move-contract-verification-from-sapphire-to-tools branch from 4d2c727 to a5c6716 Compare December 12, 2024 19:59
@rube-de rube-de force-pushed the 1029-move-contract-verification-from-sapphire-to-tools branch from 39af1a0 to 48baba1 Compare December 12, 2024 20:03
@rube-de rube-de merged commit 42bcc00 into main Dec 13, 2024
6 checks passed
@rube-de rube-de deleted the 1029-move-contract-verification-from-sapphire-to-tools branch December 13, 2024 09:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aefhm aefhm aefhm approved these changes

@matevz matevz Awaiting requested review from matevz

Assignees

@rube-de rube-de

Labels
documentation Improvements or additions to documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Move contract verification from Sapphire to Tools
2 participants
@rube-de @aefhm