Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump Docusaurus to 3.6.1 #1020

Merged
merged 3 commits into from
Nov 14, 2024
Merged

Bump Docusaurus to 3.6.1 #1020

merged 3 commits into from
Nov 14, 2024

Conversation

matevz
Copy link
Member

@matevz matevz commented Nov 13, 2024

Fixes #1018

  • bumps docusaurus to 3.6.1 and other dependencies used in the docusaurus template project
  • bumps docusaurus-search-local
  • bumps mermaid-cli to 0.45.0 which is based on mermaid 11.4.0
  • this requires installing a separate puppetteer dependency and a new config file for it to handle some sandbox annoyances
  • bumps node to >=20 required by the new mermaid-cli version

@netlify Netlify
Copy link

netlify bot commented Nov 13, 2024 •
edited
Loading

✅ Deploy Preview for oasisprotocol-docs ready!

Name Link
🔨 Latest commit ec288f6
🔍 Latest deploy log https://app.netlify.com/sites/oasisprotocol-docs/deploys/6735d9faf718560008c45985
😎 Deploy Preview https://deploy-preview-1020--oasisprotocol-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@matevz
deps: Bump docusaurus to 3.6.1
74659ba 
- Also bumps search-local to 0.45.0
- Also bumps mermaid-cli to the next major
  version and requires the new
  puppeteer-config.json
- Bumps node to >=20.0 since it's required
  by mermaid
- Bumps other dependencies to match the
  docusaurus template project
@matevz matevz force-pushed the matevz/deps/docusaurus-3.6.1 branch from 9e7fdf6 to 28bd754 Compare November 13, 2024 09:47
@matevz matevz requested review from rube-de, lukaw3d, lubej and aefhm and removed request for lubej November 13, 2024 09:53
@matevz matevz mentioned this pull request Nov 13, 2024
Merged
pro-wh
pro-wh reviewed Nov 13, 2024
View reviewed changes
.github/workflows/ci-links.yml
@@ -19,7 +19,7 @@ jobs:
- name: Set up Node.js
uses: actions/setup-node@v4
with:
node-version: '18.x'
node-version: '20.x'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

could go to the newest LTS 22.x. in other places we use the oldest supported LTS to test for compatibility, but this is just us building our docs, so newest is fine I think

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, I don't see why we shouldn't update across the board as Node 18 is getting dropped soon.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Netlify doesn't support node 22.x yet, only 20.x.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oh does netlify run the build for us?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oh does netlify run the build for us?

The preview pages are rendered on netlify for us. They use a separate stack running Ubuntu 20.04 and Node version up to 20.x.

pro-wh
pro-wh approved these changes Nov 13, 2024
View reviewed changes
Copy link
Contributor

@pro-wh pro-wh left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't look at any release notes

aefhm
aefhm approved these changes Nov 13, 2024
View reviewed changes
package.json
"last 1 chrome version",
"last 1 firefox version",
"last 1 safari version"
"last 3 chrome version",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Not even a year of Chrome development.

@matevz matevz force-pushed the matevz/deps/docusaurus-3.6.1 branch from 28bd754 to ec288f6 Compare November 14, 2024 11:07
@matevz matevz merged commit 579d065 into main Nov 14, 2024
6 checks passed
@matevz matevz deleted the matevz/deps/docusaurus-3.6.1 branch November 14, 2024 11:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pro-wh pro-wh pro-wh approved these changes

@kostko kostko kostko left review comments

@aefhm aefhm aefhm approved these changes

@rube-de rube-de Awaiting requested review from rube-de

@lukaw3d lukaw3d Awaiting requested review from lukaw3d

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Bump Docusaurus to 3.6.x
4 participants
@matevz @kostko @aefhm @pro-wh