Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix USB in macOS releases #243

Merged
merged 1 commit into from
May 24, 2024
Merged

Fix USB in macOS releases #243

merged 1 commit into from
May 24, 2024

Conversation

jberci
Copy link
Contributor

@jberci jberci commented May 21, 2024

No description provided.

@netlify Netlify
Copy link

netlify bot commented May 21, 2024 •
edited
Loading

✅ Deploy Preview for oasisprotocol-cli canceled.

Name Link
🔨 Latest commit ff31c7f
🔍 Latest deploy log https://app.netlify.com/sites/oasisprotocol-cli/deploys/664f6ddd3d0bd30008a3ddc2

@jberci jberci marked this pull request as ready for review May 22, 2024 13:38
@jberci jberci force-pushed the jberci/fix/macos branch from 3cfa771 to ad280c0 Compare May 22, 2024 14:15
@jberci jberci requested review from matevz and kostko May 22, 2024 14:24
matevz
matevz requested changes May 22, 2024
View reviewed changes
.goreleaser.yaml Outdated Show resolved Hide resolved
@jberci
feat(build): Fix USB in macOS releases
ff31c7f 
As an aside, also add Linux aarch64 builds.
@jberci jberci force-pushed the jberci/fix/macos branch from ad280c0 to ff31c7f Compare May 23, 2024 16:24
matevz
matevz approved these changes May 24, 2024
View reviewed changes
Copy link
Member

@matevz matevz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Try moving build-common outside of the builds category. Otherwise LGTM.

@jberci jberci merged commit 06baa71 into master May 24, 2024
4 checks passed
@jberci jberci deleted the jberci/fix/macos branch May 24, 2024 14:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kostko kostko kostko approved these changes

@matevz matevz matevz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jberci @matevz @kostko