Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Line number requires specified language #240

Merged
merged 1 commit into from
May 16, 2024

Conversation

matevz
Copy link
Member

@matevz matevz commented May 15, 2024

This is the behavior introduced by oasisprotocol/docs#820. This is also the same as in the official markdown code block.

e.g. This doesn't work

```{2-3}
a
b
c
d
```

but this does:

```text {2-3}
a
b
c
d
```

Copy link

netlify bot commented May 15, 2024

Deploy Preview for oasisprotocol-cli ready!

Name Link
🔨 Latest commit 0dffbb4
🔍 Latest deploy log https://app.netlify.com/sites/oasisprotocol-cli/deploys/6644816f4ddcec0008826bcf
😎 Deploy Preview https://deploy-preview-240--oasisprotocol-cli.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@matevz matevz requested a review from lubej May 15, 2024 09:33
Copy link

@lubej lubej left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any reason why this changes aren't included in oasisprotocol/docs#820?

@matevz
Copy link
Member Author

matevz commented May 16, 2024

Any reason why this changes aren't included in oasisprotocol/docs#820?

You probably meant https://github.com/oasisprotocol/cli/pull/238/files#diff-f47f6c25f8613e21081f4dd5cbbcdd07aaa87b7ebf8898b1ddfbde86cfedd1c5R43 ? Because the initial implementation of ![code {4}](snippet.out) didn't actually work, but my tests used a cached version of the docs and thought it worked when merging it.

@matevz matevz merged commit ff10504 into master May 16, 2024
4 checks passed
@matevz matevz deleted the matevz/docs/fix-line-number branch May 16, 2024 09:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants