Bump client-sdk to 0.8.1 #206
Conversation
✅ Deploy Preview for oasisprotocol-cli canceled.
|
There was a problem hiding this comment.
Please also update the following files to reflect the new .io domain:
- examples/account/config/cli.toml
- examples/addressbook/config/cli.toml
- examples/network-set-rpc/01-set-rpc.in
- examples/network-set-rpc/config/cli.toml
- examples/network/add-tcpip.in.static
- examples/network/config/cli.toml
- examples/paratime-remove/config/cli.toml
- examples/wallet/config/cli.toml
| @@ -17,15 +17,23 @@ import ( | |||
| ) | |||
|
|
|||
| var transferCmd = &cobra.Command{ | |||
| Use: "transfer <amount> <to>", | |||
| Use: "transfer <amount> [<denom>] <to>", | |||
There was a problem hiding this comment.
Interesting usage. I was thinking of introducing a slightly different flow for setting the validator's commission fee without the space character (e.g. --bounds 329000/2%/4%). A separate denominator argument makes sense here though. 👍
But then it won't test the migrations? Maybe I'll add an explicit one for testing migrations. |
kostko
force-pushed
the
kostko/feature/rpcs-and-denoms
branch
from
3792167 to
5dd9b09
Compare
|
Done, please take another look. |
kostko
force-pushed
the
kostko/feature/rpcs-and-denoms
branch
from
5dd9b09 to
80f628b
Compare
There was a problem hiding this comment.
I tested the new denomination-specific operations and they work fine. However, I would suggest the following additions (can be in another PR):
oasis paratime listshould have another columnDENOMINATION(S)containing comma-separated currencies, number of decimals and the default one marked with(*). For exampleEUROe[18] (*), TEST[18]- new subcommand
oasis paratime denomwithadd <network> <paratime> <denomination> <number_of_decimals>remove <network> <paratime> <denomination>- in the future, other ERC-20 related operations will also be covered by the
denomsubcommand
- the list of registered denominations. This should probably go inside the
oasis paratime show <paratime>
| continue | ||
| } | ||
|
|
||
| pt.ConsensusDenomination = ptCfg.ConsensusDenomination |
There was a problem hiding this comment.
In the migrated config file I notcied the consensus denomination is set to _:
[networks.mainnet.denomination]
decimals = 9
symbol = 'ROSE'
[networks.mainnet.paratimes.sapphire]
consensus_denomination = '_'Is this expected?
There was a problem hiding this comment.
Yeah this is because the native denomination is represented by an empty string which is not handled correctly during config loading.
There should also be a section under paratime denominations named _ representing the native denomination of the paratime.
This also adds RPC endpoint migrations and improvements to support for different denominations.