Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

wallet: Add import-file command #146

Merged
merged 3 commits into from
Oct 19, 2023
Merged

Conversation

matevz
Copy link
Member

@matevz matevz commented Oct 19, 2023

This PR:

  • adds the new wallet import-file command for importing the existing keypair from the PEM file. This helps existing node operators to vote on the upcoming network upgrade, because the governance operations were deprecated in oasis-node and they are forced to use the Oasis CLI
  • refactors the wallet command into its own subfolder
  • adds Network-Account selectors admonitions to the network command as well

Fixes #140.

cmd/wallet/remoteSigner.go Outdated Show resolved Hide resolved
@matevz matevz force-pushed the matevz/feature/wallet-import-file branch from ec65fc2 to 29c7813 Compare October 19, 2023 09:56
@matevz matevz force-pushed the matevz/feature/wallet-import-file branch from e8d552c to 6b4340e Compare October 19, 2023 10:51
@matevz matevz marked this pull request as ready for review October 19, 2023 10:56
@matevz matevz force-pushed the matevz/feature/wallet-import-file branch from 6b4340e to b9d4286 Compare October 19, 2023 11:08
@matevz matevz force-pushed the matevz/feature/wallet-import-file branch from b9d4286 to 43a05bf Compare October 19, 2023 11:20
Copy link
Member

@kostko kostko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would be cool to also have an example/test that performs the import.

cmd/wallet/import_file.go Outdated Show resolved Hide resolved
@matevz matevz force-pushed the matevz/feature/wallet-import-file branch 2 times, most recently from 2afc954 to a5baf39 Compare October 19, 2023 11:34
@matevz matevz force-pushed the matevz/feature/wallet-import-file branch from a5baf39 to 3f33600 Compare October 19, 2023 11:40
@matevz
Copy link
Member Author

matevz commented Oct 19, 2023

Would be cool to also have an example/test that performs the import.

Testing the interactive commands is tricky. We could add --yes for import-file and other wallet (import, create) commands as well, but I don't think it's a good idea to encourage people having unencrypted accounts in their wallet. Let's leave this for another PR.

@matevz matevz merged commit 70d9313 into master Oct 19, 2023
3 checks passed
@matevz matevz deleted the matevz/feature/wallet-import-file branch October 19, 2023 12:09
@kostko
Copy link
Member

kostko commented Oct 19, 2023

but I don't think it's a good idea to encourage people having unencrypted accounts in their wallet

Yeah we could just use it for tests but not include it in docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CLI docs for node operators
2 participants