Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(wallet/ledger): Derivation of sr25519 addresses #122

Merged
merged 2 commits into from
Sep 26, 2023
Merged

fix(wallet/ledger): Derivation of sr25519 addresses #122

merged 2 commits into from
Sep 26, 2023

Conversation

matevz
Copy link
Member

@matevz matevz commented Aug 28, 2023 •
edited
Loading

This PR:

  • Adds new Sr25519 address derivation (in addition to Ed25519 derivation) to sanity check when obtaining the public key from the device. Noticed while testing Dev Zondax/ledger-oasis#206.
  • Bumps examples.

@matevz matevz force-pushed the matevz/fix/sr25519-ledger-address branch from 47d847e to 00654d4 Compare September 26, 2023 08:31
@matevz matevz merged commit 517ad46 into master Sep 26, 2023
3 checks passed
@matevz matevz deleted the matevz/fix/sr25519-ledger-address branch September 26, 2023 08:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kostko kostko kostko approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@matevz @kostko