Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

wallet: Sr25519 file-signer support #119

Merged
merged 1 commit into from
Sep 26, 2023
Merged

wallet: Sr25519 file-signer support #119

merged 1 commit into from
Sep 26, 2023

Conversation

matevz
Copy link
Member

@matevz matevz commented Aug 21, 2023 •
edited
Loading

Followup to #109
Integrates oasisprotocol/curve25519-voi#121 into CLI.

@matevz
Copy link
Member Author

matevz commented Aug 24, 2023 •
edited
Loading

Some test vectors obtained directly from the Ledger's derivation for the test mnemonic:

PIN: 5555
Mnemonic: equip will roof matter pink blind book anxiety banner elbow sun young
Algorithm Number Public Key Address
sr25519-adr8 0 1CSsKQujFkB3X+8ch/+umC7+uNL/4sSzPWJfbAHxlG0= oasis1qzkpf5wrzr9z22827ua44efsvm86yksdzvctsq6r
sr25519-adr8 1 CPGPz5KFeFkNlx7rkKwyfCCof1kghlY15Gf6yUzrMxM= oasis1qqdpchg8gsprewelyy2f9gx2gn9u2wmq2uhj9t5q
sr25519-adr8 2 DHym/Mo3e1nCMclw/eSSlU4OWf+h2ePpkrD3HR8kWzY= oasis1qz4u9xe36yn4xqwuzqtra0uhyewprg6fqg79zfk7
sr25519-adr8 3 hhaCSH9yzK9HxuiErQpahQKMatAVXALdE215qcgd9DM= oasis1qqfk22vhrqpxxh0qgr29c0x0vy833fcv3un7nx85

I generated those by using Oasis CLI:

oasis w create test_ledger_sr25519_testingkey_3 --kind ledger --ledger.number 3 --file.algorithm sr25519-adr8
oasis w show test_ledger_sr25519_testingkey_3

And their ed25519 counterparts:

Algorithm Number Public Key Address
ed25519-adr8 0 RWAfdhrxfbpQJDUp5ilzLxxY0I/92qhJEjhUBHVynYU= oasis1qqjkrr643qv7yzem6g4m8rrtceh42n46usfscpcf
ed25519-adr8 1 J+0Eo8Dc7GWRwAHk6jB9ZcvXEsuQ2Fq3cDw17uB6d90= oasis1qp42qp8d5k8pgekvzz0ld47k8ewvppjtmqg7t5kz
ed25519-adr8 2 GUVqPwzz9MxebOUt71fZK7PFplH6liayRs/sB6vChyQ= oasis1qqnwwhj4qvtap422ck7qjxf7wm89tgjhwczpu0f3
ed25519-adr8 3 klSQRiFP20cpv3pu5KO70PRjxHasyTOyx8zghFCavuQ= oasis1qp36crawwyk0gnfyf0epcsngnpuwrz0mtu8qzu2f

@kostko kostko marked this pull request as draft August 24, 2023 09:59
@kostko kostko force-pushed the matevz/feature/sr25519 branch 4 times, most recently from cc7ead4 to 9e0b2ce Compare September 25, 2023 10:41
@matevz
Copy link
Member Author

matevz commented Sep 26, 2023

New test vectors after incorporating Zondax/ledger-oasis#207:

Algorithm Number Public Key Address
sr25519-adr8 0 vP1R5MMzR/r9ricymYpPbBA9JvmlixdzlEYWEpx5ExY= oasis1qr9af6sfg3gmv5nefxkq7k7cxpz48r0wlu2j9frf
sr25519-adr8 1 Ql96gaTGV7o0QzQbvPBSQfRT5K9PtBNLrxEh9kMV228= oasis1qz6hzarqhmgvjaam5kpvagd0czqrflc39sgtt89h
sr25519-adr8 2 qhbwbWt9k+3SW+68NxXq3knl2jokiGpc11DoKOrjTjo= oasis1qp6nuqrjucnm64nnhp98kh9u0mlgwkkssqnrhsf9
sr25519-adr8 3 skCcMfU7D0olbxZtn8lLn0u41rJzxiCw7rcv3uVEw3Y= oasis1qz3sz6s86k9l3hlk78s25x29esn5qq43rvrkrgey

@kostko kostko force-pushed the matevz/feature/sr25519 branch 2 times, most recently from af87f52 to a5981e0 Compare September 26, 2023 08:55
@matevz matevz marked this pull request as ready for review September 26, 2023 08:57
@matevz matevz force-pushed the matevz/feature/sr25519 branch from a5981e0 to a4fa011 Compare September 26, 2023 08:58
@matevz matevz force-pushed the matevz/feature/sr25519 branch from a4fa011 to e227b92 Compare September 26, 2023 08:59
@matevz matevz merged commit d35c41e into master Sep 26, 2023
3 checks passed
@matevz matevz deleted the matevz/feature/sr25519 branch September 26, 2023 09:12
@matevz matevz mentioned this pull request Dec 12, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kostko kostko kostko approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@matevz @kostko