Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nixos19.09 #42

Open
wants to merge 24 commits into
base: master
Choose a base branch
from
Open

Nixos19.09 #42

wants to merge 24 commits into from

Conversation

augu5te
Copy link

@augu5te augu5te commented Jan 7, 2020

No description provided.

@augu5te augu5te requested a review from npf January 7, 2020 17:03
Copy link
Contributor

@npf npf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See comments inline.

Todos:

  • rework the recipes extension → nixos-base.yaml, then nixos-<version>.yaml extending it.
  • fix the qemu disk image format issue
  • fix the export method to use the default one from base.yaml or use the correct helper script

steps/bootstrap/prepare_disk.yaml Outdated Show resolved Hide resolved
from_scratch/nixos-19.03.yaml Outdated Show resolved Hide resolved
Comment on lines 50 to 56
- exec_local: |
MNT=$(mktemp -d)
sudo mount -o loop,offset=32768 $${image_disk}.$${image_format} $MNT
sudo tar -czf $${appliance_filename}.tgz -C $MNT .
sudo chmod 666 $${appliance_filename}.tgz
sudo umount $MNT
rm -r $MNT
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This step makes running the kameleon build command require the root privileges, which is not necessary for any other recipe. Rather use the export_appliance helper (which uses guestmount but does not need root privileges).

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was unaware of this

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The build VM is not bootable (bootloader installed ?). As a result, guestmount does not work for the export.

Since we would like to possibly export qcow files as well, making the qcow file bootable seems a good idea.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

guestmount is not looking for a bootloader but for vmlinuz and initrd files to extract and use directly within qemu. This seems to not function with nixos partitioning / non-standard file hierarchy. Need to dive in and find out how to possibly give some insight to guestmount with its -m option.

from_scratch/nixos-19.09.yaml Outdated Show resolved Hide resolved
@npf npf force-pushed the nixos19.09 branch 2 times, most recently from 53ff675 to c745bbe Compare February 6, 2020 10:36
@npf
Copy link
Contributor

npf commented Feb 6, 2020

In and Out context are not defined. Only the qemu-sendkeys functions for now. The recipe lacks this to enable using the setup section.

npf added 8 commits May 4, 2020 00:17
- Have the ssh keys readly before the installer runs, so that they can
be used right away in the installer.
- Start http before preparing the autoinstall script, so that the
HTTP_PORT is known and can be http service can be used in the
autoinstall script.
…not work with nixos)

Do not use virt-customize to push the ssh key of root because that does
not work with nixos, push it earlier in the autoinstall script.
…age.

This should be done before export, not right away, so that debugging in
the qemu vnc console is possible.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants