Revert build script changes #425
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Yohahaha
reviewed
Oct 27, 2023
| @@ -27,7 +27,6 @@ if(VELOX_ENABLE_ARROW) | |||
| set(ARROW_PREFIX "${CMAKE_CURRENT_BINARY_DIR}/arrow_ep") | |||
| set(ARROW_CMAKE_ARGS | |||
| -DARROW_PARQUET=ON | |||
| -DARROW_FILESYSTEM=ON | |||
There was a problem hiding this comment.
In file included from ../core/shuffle/LocalPartitionWriter.cc:18:
../core/shuffle/LocalPartitionWriter.h:20:10: fatal error: arrow/filesystem/localfs.h: No such file or directory
20 | #include <arrow/filesystem/localfs.h>
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~
@marin-ma Does ARROW_FILESYSTEM not needed?
Yohahaha
reviewed
Oct 27, 2023
|
|
||
| #pragma once | ||
|
|
||
| +#include <cassert> |
There was a problem hiding this comment.
/root/oap-velox/_build/release/third_party/arrow_ep/install/include/arrow/c/helpers.h: In function ‘void ArrowSchemaMove(ArrowSchema*, ArrowSchema*)’:
/root/oap-velox/_build/release/third_party/arrow_ep/install/include/arrow/c/helpers.h:53:3: error: ‘assert’ was not declared in this scope
53 | assert(dest != src);
| ^~~~~~
|
@Yohahaha Please try to upgrade Gluten to at least this commit: apache/incubator-gluten@eb46721. These changes are applied from Gluten during compilation. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.