Revert "Add RowConstructorWithNull expression (374)" (#420)

This reverts commit 556839d.
oap-project · Oct 24, 2023 · 6c764e8 · 6c764e8
1 parent 8d0a264
commit 6c764e8
Show file tree

Hide file tree

Showing 7 changed files with 0 additions and 190 deletions.
diff --git a/velox/expression/CMakeLists.txt b/velox/expression/CMakeLists.txt
@@ -36,7 +36,6 @@ add_library(
   VectorFunction.cpp
   RegisterSpecialForm.cpp
   RowConstructor.cpp
-  RowConstructorWithNull.cpp
   SimpleFunctionRegistry.cpp
   SpecialFormRegistry.cpp
   SwitchExpr.cpp

diff --git a/velox/expression/RegisterSpecialForm.cpp b/velox/expression/RegisterSpecialForm.cpp
@@ -22,7 +22,6 @@
 #include "velox/expression/ConjunctExpr.h"
 #include "velox/expression/FunctionCallToSpecialForm.h"
 #include "velox/expression/RowConstructor.h"
-#include "velox/expression/RowConstructorWithNull.h"
 #include "velox/expression/SpecialFormRegistry.h"
 #include "velox/expression/SwitchExpr.h"
 #include "velox/expression/TryExpr.h"
@@ -48,8 +47,5 @@ void registerFunctionCallToSpecialForms() {
   registerFunctionCallToSpecialForm(
       RowConstructorCallToSpecialForm::kRowConstructor,
       std::make_unique<RowConstructorCallToSpecialForm>());
-  registerFunctionCallToSpecialForm(
-      RowConstructorWithNullCallToSpecialForm::kRowConstructorWithNull,
-      std::make_unique<RowConstructorWithNullCallToSpecialForm>());
 }
 } // namespace facebook::velox::exec
diff --git a/velox/expression/RowConstructorWithNull.cpp b/velox/expression/RowConstructorWithNull.cpp
diff --git a/velox/expression/RowConstructorWithNull.h b/velox/expression/RowConstructorWithNull.h
diff --git a/velox/functions/prestosql/CMakeLists.txt b/velox/functions/prestosql/CMakeLists.txt
@@ -47,7 +47,6 @@ add_library(
   Repeat.cpp
   Reverse.cpp
   RowFunction.cpp
-  RowFunctionWithNull.cpp
   Sequence.cpp
   SimpleComparisonMatcher.cpp
   Slice.cpp

diff --git a/velox/functions/prestosql/RowFunctionWithNull.cpp b/velox/functions/prestosql/RowFunctionWithNull.cpp
diff --git a/velox/functions/prestosql/registration/GeneralFunctionsRegistration.cpp b/velox/functions/prestosql/registration/GeneralFunctionsRegistration.cpp
@@ -25,8 +25,6 @@ void registerAllSpecialFormGeneralFunctions() {
   exec::registerFunctionCallToSpecialForms();
   VELOX_REGISTER_VECTOR_FUNCTION(udf_in, "in");
   VELOX_REGISTER_VECTOR_FUNCTION(udf_concat_row, "row_constructor");
-  VELOX_REGISTER_VECTOR_FUNCTION(
-      udf_concat_row_with_null, "row_constructor_with_null");
   registerIsNullFunction("is_null");
 }