Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ML-381] Fix LR bugs #385

Merged
merged 17 commits into from
Sep 10, 2024
Merged

[ML-381] Fix LR bugs #385

merged 17 commits into from
Sep 10, 2024

Conversation

minmingzhu
Copy link
Collaborator

@minmingzhu minmingzhu commented Aug 19, 2024 •
edited
Loading

What changes were proposed in this pull request?

closes #381

Fixed LR the following issues:

  1. OneDAL LR doesn't support weight column. Removed the code that determines whether a weight column exists.
  2. Add caching to uncached dataset.

@minmingzhu minmingzhu changed the title [ML-381] fix LR bugs [ML-381] Fix LR bugs Aug 19, 2024
@minmingzhu minmingzhu requested a review from xwu99 August 20, 2024 01:50
@xwu99 xwu99 merged commit e307341 into oap-project:master Sep 10, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xwu99 xwu99 xwu99 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[LinearRegression] Fix cache bugs and change the logic of entering the DAL function
2 participants
@minmingzhu @xwu99