Interface fixes

[RitaOak]

This change is 

[RitaOak]

But we always had a .gitignore. What is this witchcraft?

[brecke]

Ok, so:

• Remove comments that we no longer need
• Remind me again why we need a bunch of (temporary) V2 files
• Feel free to remove old scaffolding files at will

Reviewed 20 of 25 files at r1, 5 of 5 files at r2.
Reviewable status: all files reviewed, 5 unresolved discussions (waiting on @RitaOak)

---

src/components/shop-products.js, line 13 at r2 (raw file):

/* eslint-disable import/no-unassigned-import */

class ShopProducts extends PageViewElement {

why don't you just erase it? this is a file from the project template

---

src/components/sidebarV2.js, line 1 at r2 (raw file):

import { html, LitElement } from 'lit-element';

what does V2 mean?

---

src/components/top-navV2.js, line 1 at r2 (raw file):

import { html, LitElement } from 'lit-element';

Why do we need a V2?

---

style/app.scss, line 168 at r2 (raw file):

.menu {
  width: 185px;
  //position: fixed;

do we need these comments? and the others above?

---

style/topnav-buttons.scss, line 19 at r2 (raw file):

  font-size: 14px;
  height: 35px;
  //border-radius: 25px;

do we need these?

[RitaOak]

---

style/app.scss, line 168 at r2 (raw file):

Previously, brecke (Miguel Laginha) wrote…

do we need these comments? and the others above?

they're helpers to revert to a previous layout, nothing too important but that should stay for now

[RitaOak]

---

style/topnav-buttons.scss, line 19 at r2 (raw file):

Previously, brecke (Miguel Laginha) wrote…

do we need these?

same as before

[RitaOak]

---

src/components/shop-products.js, line 13 at r2 (raw file):

Previously, brecke (Miguel Laginha) wrote…

why don't you just erase it? this is a file from the project template

I've been trying to delete the shop files, but for some reason they cause the project to send several error messages. It didn't crash, but hours later I still haven't figured out where the problem lies, so I'll just leave those files for now.

[RitaOak]

Reviewable status: all files reviewed, 5 unresolved discussions (waiting on @brecke)

---

src/components/sidebarV2.js, line 1 at r2 (raw file):

Previously, brecke (Miguel Laginha) wrote…

what does V2 mean?

Done.

---

src/components/top-navV2.js, line 1 at r2 (raw file):

Previously, brecke (Miguel Laginha) wrote…

Why do we need a V2?

Done.

[brecke]

Reviewed 12 of 12 files at r3.
Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @RitaOak)

---

src/components/shop-products.js, line 13 at r2 (raw file):

Previously, RitaOak (Rita Oak) wrote…

I've been trying to delete the shop files, but for some reason they cause the project to send several error messages. It didn't crash, but hours later I still haven't figured out where the problem lies, so I'll just leave those files for now.

lol ok
create an issue for that on github if you please

---

style/app.scss, line 168 at r2 (raw file):

Previously, RitaOak (Rita Oak) wrote…

they're helpers to revert to a previous layout, nothing too important but that should stay for now

then expand the comment to say that explicitly. Even you won't know what they're for in a year otherwise :)

---

style/topnav-buttons.scss, line 19 at r2 (raw file):

Previously, RitaOak (Rita Oak) wrote…

same as before

do as I suggested then

[RitaOak]

Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @brecke)

---

style/app.scss, line 168 at r2 (raw file):

Previously, brecke (Miguel Laginha) wrote…

then expand the comment to say that explicitly. Even you won't know what they're for in a year otherwise :)

Done.

---

style/topnav-buttons.scss, line 19 at r2 (raw file):

Previously, brecke (Miguel Laginha) wrote…

do as I suggested then

Done.

[brecke]

Reviewed 2 of 4 files at r4.
Reviewable status: complete! all files reviewed, all discussions resolved