Interface updatesv2

[RitaOak]

This change is 

[brecke]

Reviewed 9 of 9 files at r1.
Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @RitaOak)

---

images/user.jpg, line 0 at r1 (raw file):
I think we should do something about the image filesizes. Let's create a github issue on Biscuit-ux to deal with this sometime at a later stage, shall we? I'm guessing there are ways to deal with this, just not sure which ones.

---

style/topnav-buttons.scss, line 25 at r1 (raw file):

.notification-icon {
  color: black;

A longe time ago I read the following: https://ianstormtaylor.com/design-tip-never-use-black/

What do you make of this?

[brecke]

Reviewed 9 of 9 files at r2.
Reviewable status: all files reviewed, 3 unresolved discussions (waiting on @RitaOak)

---

style/news-feed.scss, line 5 at r2 (raw file):

  box-shadow: none;
  background-color: white;
  //box-shadow: 0 3px 6px rgba(0, 0, 0, 0.16), 0 3px 6px rgba(0, 0, 0, 0.23);

why the comment?

[RitaOak]

---

images/user.jpg, line at r1 (raw file):

Previously, brecke (Miguel Laginha) wrote…

I think we should do something about the image filesizes. Let's create a github issue on Biscuit-ux to deal with this sometime at a later stage, shall we? I'm guessing there are ways to deal with this, just not sure which ones.

Issue created. Tagged you

[RitaOak]

---

style/news-feed.scss, line 5 at r2 (raw file):

Previously, brecke (Miguel Laginha) wrote…

why the comment?

experimenting with something, will remove in due time

[RitaOak]

---

style/topnav-buttons.scss, line 25 at r1 (raw file):

Previously, brecke (Miguel Laginha) wrote…

A longe time ago I read the following: https://ianstormtaylor.com/design-tip-never-use-black/

What do you make of this?

Pure black is bad for contrast (which affects accessibility). At this point I was experimenting to check how the overall interface would respond to a brutal change from saturated black to 100% black, but meanwhile I've normalized the colours.

[RitaOak]

Reviewable status: 12 of 14 files reviewed, 3 unresolved discussions (waiting on @brecke)

---

images/user.jpg, line at r1 (raw file):

Previously, RitaOak (Rita Oak) wrote…

Issue created. Tagged you

Done.

---

style/news-feed.scss, line 5 at r2 (raw file):

Previously, RitaOak (Rita Oak) wrote…

experimenting with something, will remove in due time

Done.

---

style/topnav-buttons.scss, line 25 at r1 (raw file):

Previously, RitaOak (Rita Oak) wrote…

Pure black is bad for contrast (which affects accessibility). At this point I was experimenting to check how the overall interface would respond to a brutal change from saturated black to 100% black, but meanwhile I've normalized the colours.

Done.

[brecke]

Reviewed 2 of 2 files at r3.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @RitaOak)

---

src/components/dashboard.js, line 4 at r3 (raw file):

import sharedStyles from '../../style/app.scss';
import dashboardStyles from '../../style/dashboard.scss';
import dashboardButtonsStyles from '../../style/dashboard-filter.scss';

why separate styles for buttons and the rest?