fix: Fixed iso dropdown in Run Once window

oVirt · Sep 3, 2024 · e8bbc4b · e8bbc4b
1 parent 7d868bf
commit e8bbc4b
Show file tree

Hide file tree

Showing 5 changed files with 22 additions and 10 deletions.
diff --git a/frontend/brands/ovirt-brand/src/main/resources/bundled/patternfly/css/patternfly.css b/frontend/brands/ovirt-brand/src/main/resources/bundled/patternfly/css/patternfly.css
@@ -9457,7 +9457,7 @@ fieldset[disabled] .btn-primary.active {
   top: auto;
 }
 .open .dropdown-submenu.active > .dropdown-menu {
-  display: block;
+  display: grid;
 }
 .dropdown-kebab-pf.btn-group > .btn:first-child,
 .dropdown-kebab-pf .btn-link {

diff --git a/frontend/brands/ovirt-brand/src/main/resources/bundled/patternfly/css/patternfly.min.css b/frontend/brands/ovirt-brand/src/main/resources/bundled/patternfly/css/patternfly.min.css
diff --git a/...s/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/editor/ListModelListBox.java b/...s/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/editor/ListModelListBox.java
@@ -81,6 +81,7 @@ interface Style extends CssResource {
         String label();
         String selectedValue();
         String button();
+        String buttonSelected();
     }
 
     interface ListItemTemplate extends SafeHtmlTemplates {
@@ -169,6 +170,7 @@ private Button createButton() {
         button.getElement().setAttribute(DATA_TOGGLE, Styles.DROPDOWN);
         selectedValue = Document.get().createSpanElement();
         selectedValue.addClassName(FILTER_OPTION);
+        selectedValue.addClassName(style.buttonSelected());
         selectedValue.addClassName(Styles.PULL_LEFT); //$NON-NLS-1$
         selectedValue.setInnerHTML(NBSP);
         return button;
@@ -387,7 +389,7 @@ public void scrollToSelected() {
                 if (child instanceof ListModelListBox.ListItem) {
                     final ListItem item = (ListModelListBox<T>.ListItem) child;
                     if (item.isSelected()) {
-                        Scheduler.get().scheduleDeferred(() -> item.getElement().scrollIntoView());
+                         Scheduler.get().scheduleDeferred(() -> scrollIntoView(item.getElement()));
                     }
                 }
             }
@@ -447,6 +449,10 @@ public void clear() {
             getClickHandlers().clear();
             getElement().removeAllChildren();
         }
+
+        private native void scrollIntoView(Element element) /*-{
+            element.scrollIntoView({block: "nearest", inline: "nearest"});
+        }-*/;
     }
 
     protected class ListItem extends ComplexPanel {

diff --git a/...gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/editor/ListModelListBox.ui.xml b/...gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/editor/ListModelListBox.ui.xml
@@ -10,23 +10,27 @@
             padding-right: 25px;
         }
 
+        .buttonSelected {
+            overflow: hidden;
+            text-overflow: ellipsis;
+        }
+
         .fullWidth {
             width: 100%!important;
         }
 
         .scrollableMenu {
             height: auto;
             max-height: 130px;
-            overflow-x: hidden;
-            width: auto;
+            overflow-x: auto;
+            width: 100%;
             min-width: 100%;
         }
 
         .selected {
             background-color: #0099d3!important;
             border-color: #0076b7!important;
             color: #fff!important;
-            padding-right: 40px!important;
         }
 
         .selectedValue {
@@ -41,6 +45,7 @@
 
         .liPosition {
             position: relative;
+            width: 100%;
         }
 
         .inlineBlock {

diff --git a/...main/java/org/ovirt/engine/ui/common/widget/uicommon/popup/vm/VmRunOncePopupWidget.ui.xml b/...main/java/org/ovirt/engine/ui/common/widget/uicommon/popup/vm/VmRunOncePopupWidget.ui.xml
@@ -40,6 +40,7 @@
     }
 
     .panelStyle {
+      table-layout: fixed;
       background: #e5ecff;
       border-top: 2px solid white;
       width: 100%;