Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adding the parameter safe_domain in case there is a specific value #9

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

gdraperi
Copy link

Hello,

I had a situation where safe_domain was different from the tenant and the domain and I had to setup a specific value.
https://{self.tenant_name}-my.{self.endpoint}/personal/{safeusername}_{self.safe_domain}/_layouts/15/onedrive.aspx'

I added an option to specify it and in the default case it comes back to the domain value to generate the safe domain.

@nyxgeek
Copy link
Owner

nyxgeek commented Jun 14, 2023

I appreciate the PR! However I believe it may be unnecessary --

The safe_domain is derived directly from the -d parameter, but the periods are replaced with underscores. If you need a different 'safe_domain', simply change the -d parameter to the domain you would like it to use, BUT be sure to specify a tenant with -t so that it doesn't try to do autolookup. I see how that could cause confusion -- going to make a wiki to go over some use cases with examples.

Could you give that a try and confirm if that works? Feel free to DM me (@nyxgeek on twitter) if you would be okay with sharing some specifics.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants