Add IfSuppressedFile generator #5
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ekate
commented
Feb 28, 2024
There was a problem hiding this comment.
@rrasch could you add tests for the new generator. Similar to ones that was done here
You can also put SUPPRESSED_NAME to config file and add ULTRAVIOLET_ prefix to it name i
- Add new fixtures for creating records that are linked to buckets passed in as arguments
- Check if file_records is empty because all() will return True instead of the expected value of False if list is empty - Use generator instead of list comprehension inside all() to make it short circuited
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.