This repository has been archived by the owner on Mar 6, 2019. It is now read-only.
Updates for speed and python 3 compatibility #7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Prevent extra newlines from being included in the output - Updates to make script python2/3 compatible
- Replace generate data for loop with a pool of worker processes for processing each line of the training input file in a separate process - Move writing the output data to a seperate process which reads from the queue filled by the worker processes
|
I can confirm this works when set up correctly. On macs the code to get a processor count will fail (line 4 of roundtrip.sh), but it is easy to hardcode a number. |
|
there is an error on rountrip.sh also it seems not to generate test data |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As I started to use this system, I started making changes which I think could be useful to others.
On my system with 8 cores, I noticed a 7.5x reduction in processing time to run roundup.sh with the provided dataset.