Merge branch 'release/2.4.54' into craft-webpack

nystudio107 · Dec 25, 2021 · ef8873a · ef8873a
2 parents 761356f + 9ceceb7
commit ef8873a
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 2 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -1,5 +1,9 @@
 # nystudio107/craft Change Log
 
+## 2.4.54 - 2021.12.25
+### Fixed
+* Fixed an issue with Critical CSS not generating properly out of the box
+
 ## 2.4.53 - 2021.12.25
 ### Fixed
 * Fix `node-dev-webpack/Dockerfile` so `npm install` is run

diff --git a/buildchain/webpack-configs/critical.config.js b/buildchain/webpack-configs/critical.config.js
@@ -16,7 +16,6 @@ module.exports = (type = 'modern', settings) => {
                     target: criticalDest,
                     extract: false,
                     inline: false,
-                    minify: true,
                     width: settings.critical.criticalWidth,
                     height: settings.critical.criticalHeight,
                 })

diff --git a/buildchain/webpack-settings/app.settings.js b/buildchain/webpack-settings/app.settings.js
@@ -25,7 +25,7 @@ module.exports = {
         dist: path.resolve('../cms/web/dist/'),
     },
     urls: {
-        criticalCss: 'http://example.test/',
+        criticalCss: 'http://webpack:8080/',
         publicPath: () => process.env.PUBLIC_PATH || '/dist/',
     },
 };