-
-
Notifications
You must be signed in to change notification settings - Fork 71
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
v4 Documentation Freshening #1409
Merged
khalwat
merged 30 commits into
nystudio107:develop-v4
from
mattstein:feature/docs-freshening
Feb 18, 2024
Merged
v4 Documentation Freshening #1409
khalwat
merged 30 commits into
nystudio107:develop-v4
from
mattstein:feature/docs-freshening
Feb 18, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Use up-to-date Moz + Craft logos in SVG format. - Improve logo layout in docs. - Remove redundant language. - Use fenced code blocks in Installation section for more consistent format and easy copy+paste. - Edit intro to convey what it is before what it does. - Attempt to summarize core features. - Add alt text to images. - Lowercase control panel and bold click paths to follow Craft CMS documentation style. - Fix badge spacing in docs. - Use admonition for 404 redirect note. - Use title case for all headings.
- Add alt text to screenshots. - Remove wrongly-labeled `seomatic-global-security.png` screenshot. - Structure navigation into “Getting Started”, “Using SEOmatic”, and “SEO Reference” sections. - Split “Configuration” and “Twig Templating” into sub-pages for more coherent navigation. - Represent “Twig Templating” sidebar items by Twig appearance rather than page title. - Start updating Craft docs links to their modern equivalent using the right version. - Remove redundant “brought to you by” text from each page. - Start replacing “N.B.” emphasis with callouts, and sprinkle in other VitePress Markdown features when useful. - Fix various formatting for consistency and decency.
They don’t seem to be doing anything useful.
Mostly ensuring that code blocks can be read without any scrolling.
When you’re right, you’re right.
This was referenced Feb 19, 2024
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR thoroughly edits and reorganizes the docs to read like a more structured product manual that’s stylistically consistent and (hopefully) easier to navigate.
const EVENT_*
lines from the events page that don’t seem to have a clear purposeNot Done
Because time. But not the worst ideas.
seomatic-global-security.png
—which did not, in fact, depict the global security settings.What Now?
It’s ... a lot. I would recommend the following high-level tour:
If this is merge-worthy, I can follow up and apply these changes to the v3 and v5 docs. (As part of the PR or a separate one.)
Bonus
Here’s a slick way to check external and internal links (with fragments!) if you’re an animal that runs global Node.js modules right on your machine:
(Inspired by DDEV’s setup.)