Merge pull request #413 from niektenhoopen/v5

[v5] There should be an alt attribute on images if it's specified as empty
nystudio107 · Oct 19, 2024 · d2d820c · d2d820c
2 parents 8bbba2f + 079b4fb
commit d2d820c
Show file tree

Hide file tree

Showing 2 changed files with 14 additions and 4 deletions.
diff --git a/src/models/ImgTag.php b/src/models/ImgTag.php
@@ -106,8 +106,13 @@ public function render(): Markup
         if ($this->loadingStrategy !== 'eager') {
             $attrs = $this->swapLazyLoadAttrs($this->loadingStrategy, $this->placeholder, $attrs);
         }
-        // Remove any empty attributes
-        $attrs = array_filter($attrs);
+
+        // Remove any empty attributes except the alt attribute
+        $attrs = array_filter($attrs, function($value, $key) {
+            // Keep the 'alt' attribute even if it's empty
+            return $key === 'alt' || !empty($value);
+        }, ARRAY_FILTER_USE_BOTH);
+
         // Render the tag
         $tag = Html::tag('img', '', $attrs);
 

diff --git a/src/models/PictureTag.php b/src/models/PictureTag.php
@@ -174,8 +174,13 @@ public function render(): Markup
         if ($this->loadingStrategy !== 'eager') {
             $attrs = $this->swapLazyLoadAttrs($this->loadingStrategy, $this->placeholder, $attrs);
         }
-        // Remove any empty attributes
-        $attrs = array_filter($attrs);
+
+        // Remove any empty attributes except the alt attribute
+        $attrs = array_filter($attrs, function($value, $key) {
+            // Keep the 'alt' attribute even if it's empty
+            return $key === 'alt' || !empty($value);
+        }, ARRAY_FILTER_USE_BOTH);
+
         // Render the tag
         $content .= Html::tag('img', '', $attrs);
         // Handle the <picture> tag