Prep for support for more WA templates components #662
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #662 +/- ##
==========================================
- Coverage 74.25% 74.20% -0.06%
==========================================
Files 97 97
Lines 13135 13107 -28
==========================================
- Hits 9754 9726 -28
Misses 2692 2692
Partials 689 689 ☔ View full report in Codecov by Sentry. |
norkans7
commented
Nov 29, 2023
| @@ -1070,21 +1070,6 @@ var mediaCacheSendTestCases = []OutgoingTestCase{ | |||
| }, | |||
| } | |||
|
|
|||
| var hsmSupportSendTestCases = []OutgoingTestCase{ | |||
There was a problem hiding this comment.
hsm type was replaced by template, so removing support for that as that is no longer used
norkans7
commented
Nov 29, 2023
| @@ -724,39 +724,18 @@ func buildPayloads(msg courier.MsgOut, h *handler, clog *courier.ChannelLog) ([] | |||
| return nil, errors.Errorf("cannot send template message without Facebook namespace for channel: %s", msg.Channel().UUID()) | |||
| } | |||
|
|
|||
| if msg.Channel().BoolConfigForKey(configHSMSupport, false) { | |||
There was a problem hiding this comment.
removing hsm supportas that is not longer used
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
needs adjustment to the engine to send the the components in metadata instead of variables