Do not log EX MT response check error

nyaruka · Jan 9, 2025 · 9de14f4 · 9de14f4
1 parent 47e0838
commit 9de14f4
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 2 deletions.
diff --git a/handlers/external/handler.go b/handlers/external/handler.go
@@ -366,7 +366,7 @@ func (h *handler) Send(ctx context.Context, msg courier.MsgOut, res *courier.Sen
 		}
 
 		if responseCheck != "" && !strings.Contains(string(respBody), responseCheck) {
-			return courier.ErrResponseUnexpected
+			return courier.ErrFailedWithReason("mt-response-check", fmt.Sprintf("response not containing '%s'", responseCheck))
 		}
 	}
 

diff --git a/handlers/external/handler_test.go b/handlers/external/handler_test.go
@@ -834,7 +834,7 @@ var xmlSendWithResponseContentTestCases = []OutgoingTestCase{
 			Headers: map[string]string{"Content-Type": "text/xml; charset=utf-8"},
 			Body:    `<msg><to>+250788383383</to><text>Error Message</text><from>2020</from><quick_replies></quick_replies></msg>`,
 		}},
-		ExpectedError: courier.ErrResponseUnexpected,
+		ExpectedError: courier.ErrFailedWithReason("mt-response-check", "response not containing '<return>0</return>'"),
 	},
 	{
 		Label:          "Send Attachment",
-Original file line number
+Diff line change
@@ Expand Up @@
     		}
     		if responseCheck != "" && !strings.Contains(string(respBody), responseCheck) {
-    			return courier.ErrResponseUnexpected
+    			return courier.ErrFailedWithReason("mt-response-check", fmt.Sprintf("response not containing '%s'", responseCheck))
     		}
     	}
@@ Expand Down @@