Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Docs: Update README #442

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Docs: Update README #442

wants to merge 1 commit into from

Conversation

braveocheretovych
Copy link
Contributor

Added license link

nxpfrankli
nxpfrankli reviewed Nov 14, 2024
View reviewed changes
Copy link
Contributor

@nxpfrankli nxpfrankli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you update it. Please add signed-off-by tag in commit message.

@braveocheretovych
Copy link
Contributor Author

Please explain how I can update the pull requests

@nxpfrankli
Copy link
Contributor

nxpfrankli commented Nov 15, 2024 •
edited
Loading

git commit --amend -s
git push -f origin (you send pull request)

ref: https://ffeathers.wordpress.com/2020/01/12/how-to-update-your-pr-on-github/

Recently, our legal team required "signed-off-by" tag.

@braveocheretovych
Copy link
Contributor Author

I just make edits not through the terminal, but through the edit function on Github

@nxpfrankli
Copy link
Contributor

I think the simplest method is redo it. when submit change, add signed-off-by: at commit message box.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nxpfrankli nxpfrankli nxpfrankli left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@braveocheretovych @nxpfrankli